Re: Updated win32 readdir patch

Hello!

Here is an updated version of the win32 readdir patch.

1) Now puts in exactly the same change as the current-cvs mingw code
does. (see
http://cvs.sourceforge.net/viewcvs.py/mingw/runtime/mingwex/dirent.c?r1=
1.3&r2=1.4, second part of the patch).

2) Updates both xlog.c and slru.c in backend/access/transam/

3) Also updates pg_resetxlog, which also uses readdir() and checks the
errno value after the loop.

Claudio - if this is not applied, please updated the win32 status page
to point to this patch instead of the previous incomplete one.

//Magnus
<<win32_readdir.patch>>

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> Here is an updated version of the win32 readdir patch.

Do we actually need to apply this to the main CVS tree, or can we just
wait for a mingw release that includes the fix?

-Neil

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> Here is an updated version of the win32 readdir patch.

> 1) Now puts in exactly the same change as the current-cvs mingw code
> does. (see
> http://cvs.sourceforge.net/viewcvs.py/mingw/runtime/mingwex/dirent.c?r1=3D
> 1.3&r2=3D1.4, second part of the patch).

I don't really agree with cluttering our code with temporary workarounds
for a mingw bug.

regards, tom lane

Neil Conway wrote:
> "Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> > Here is an updated version of the win32 readdir patch.
>
> Do we actually need to apply this to the main CVS tree, or can we just
> wait for a mingw release that includes the fix?

We might be able to wait, but the current MinGW has other bugs so we
can't use it. I think we can include it in CVS and add a TODO to remove
it when MinGW is upgraded.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Magnus Hagander wrote:
> Hello!
>
> Here is an updated version of the win32 readdir patch.
>
> 1) Now puts in exactly the same change as the current-cvs mingw code
> does. (see
> http://cvs.sourceforge.net/viewcvs.py/mingw/runtime/mingwex/dirent.c?r1=
> 1.3&r2=1.4, second part of the patch).
>
> 2) Updates both xlog.c and slru.c in backend/access/transam/
>
> 3) Also updates pg_resetxlog, which also uses readdir() and checks the
> errno value after the loop.
>
> Claudio - if this is not applied, please updated the win32 status page
> to point to this patch instead of the previous incomplete one.
>
> //Magnus
> <<win32_readdir.patch>>

Content-Description: win32_readdir.patch

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: the planner will ignore your desire to choose an index scan if your
> joining column's datatypes do not match

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Patch applied. Thanks.

Also, I updated the Win32 patch to mention removing the patch when
runtime/mingwex/dirent.c rev 1.4 is released.

---------------------------------------------------------------------------

Magnus Hagander wrote:
> Hello!
>
> Here is an updated version of the win32 readdir patch.
>
> 1) Now puts in exactly the same change as the current-cvs mingw code
> does. (see
> http://cvs.sourceforge.net/viewcvs.py/mingw/runtime/mingwex/dirent.c?r1=
> 1.3&r2=1.4, second part of the patch).
>
> 2) Updates both xlog.c and slru.c in backend/access/transam/
>
> 3) Also updates pg_resetxlog, which also uses readdir() and checks the
> errno value after the loop.
>
> Claudio - if this is not applied, please updated the win32 status page
> to point to this patch instead of the previous incomplete one.
>
> //Magnus
> <<win32_readdir.patch>>

Content-Description: win32_readdir.patch

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: the planner will ignore your desire to choose an index scan if your
> joining column's datatypes do not match

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073