Re: [COMMITTERS] pgsql: - Add check of already changed page while replay WAL.

Lists: PostgreSQL : PostgreSQLPostg사설 토토SQL
From: teodor(at)postgresql(dot)org (Teodor Sigaev)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: - Add check of already changed page while replay WAL.
Date: 2007-10-29 19:27:21
Message-ID: 20071029192721.96381754229@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Log Message:
-----------
- Add check of already changed page while replay WAL. This touches only
ginRedoInsert(), because other ginRedo* functions rewrite whole page or
make changes which could be applied several times without consistent's loss

- Remove check of identifying of corresponding split record:
it's possible that replaying of WAL starts after actual page split, but before
removing of that split from incomplete splits list. In this case, that check
cause FATAL error.

Per stress test which reproduces bug reported by Craig McElroy
<craig(dot)mcelroy(at)contegix(dot)com>

Tags:
----
REL8_2_STABLE

Modified Files:
--------------
pgsql/src/backend/access/gin:
ginxlog.c (r1.5.2.1 -> r1.5.2.2)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gin/ginxlog.c?r1=1.5.2.1&r2=1.5.2.2)


From: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: - Add check of already changed page while replay WAL.
Date: 2007-11-09 16:46:05
Message-ID: 200711091146.06067.xzilla@users.sourceforge.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: PostgreSQL : PostgreSQL Postg사설 토토SQL

On Monday 29 October 2007 15:27, Teodor Sigaev wrote:
> Log Message:
> -----------
> - Add check of already changed page while replay WAL. This touches only
> ginRedoInsert(), because other ginRedo* functions rewrite whole page or
> make changes which could be applied several times without consistent's loss
>
> - Remove check of identifying of corresponding split record:
> it's possible that replaying of WAL starts after actual page split, but
> before removing of that split from incomplete splits list. In this case,
> that check cause FATAL error.
>
> Per stress test which reproduces bug reported by Craig McElroy
> <craig(dot)mcelroy(at)contegix(dot)com>
>
> Tags:
> ----
> REL8_2_STABLE
>
> Modified Files:
> --------------
> pgsql/src/backend/access/gin:
> ginxlog.c (r1.5.2.1 -> r1.5.2.2)
>
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gin/gi
>nxlog.c?r1=1.5.2.1&r2=1.5.2.2)
>

Not to put any pressure, but this fix had me wondering if we might see an
8.2.6 before 8.3 is out?

--
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL