pg_ctl -t N register ??

Lists: pgsql-hackerspgsql-patches
From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-hackers(at)postgresql(dot)org
Subject: pg_ctl -t N register ??
Date: 2007-11-16 15:37:58
Message-ID: 20071116153758.GA13714@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

Hi,

I just noticed that the "pg_ctl register" synopsis was updated to have a
-t parameter. This does not seem to make sense to me. Is it correct?
Does it do anything?

My thinking is that we should just remove the -t from that synopsis.

--
Alvaro Herrera Developer, http://www.PostgreSQL.org/
"Tiene valor aquel que admite que es un cobarde" (Fernandel)


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_ctl -t N register ??
Date: 2007-11-16 17:38:08
Message-ID: 200711161738.lAGHc8028867@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

Alvaro Herrera wrote:
> Hi,
>
> I just noticed that the "pg_ctl register" synopsis was updated to have a
> -t parameter. This does not seem to make sense to me. Is it correct?
> Does it do anything?
>
> My thinking is that we should just remove the -t from that synopsis.

Well, Peter added it, but register already had the -w parameter, so
either register needs both -t and -w, or it needs neither of them. I
don't know which is true.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +


From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_ctl -t N register ??
Date: 2007-11-16 19:17:28
Message-ID: 20071116191728.GB12131@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
> Alvaro Herrera wrote:
> > Hi,
> >
> > I just noticed that the "pg_ctl register" synopsis was updated to have a
> > -t parameter. This does not seem to make sense to me. Is it correct?
> > Does it do anything?
> >
> > My thinking is that we should just remove the -t from that synopsis.
>
> Well, Peter added it, but register already had the -w parameter, so
> either register needs both -t and -w, or it needs neither of them. I
> don't know which is true.

Humm, in pgwin32_CommandLine I don't see any reference to -t but -w is
there. So either

a) the bug is that somebody forgot to add -t to pgwin32_CommandLine
b) the bug is that -t was added to the synopsis, or
c) I'm full of it because of an untold reason.

--
Alvaro Herrera http://www.amazon.com/gp/registry/5ZYLFMCVHXC
"En las profundidades de nuestro inconsciente hay una obsesiva necesidad
de un universo lógico y coherente. Pero el universo real se halla siempre
un paso más allá de la lógica" (Irulan)


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] pg_ctl -t N register ??
Date: 2007-11-20 19:24:13
Message-ID: 200711201924.lAKJODi19619@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Alvaro Herrera wrote:
> > > Hi,
> > >
> > > I just noticed that the "pg_ctl register" synopsis was updated to have a
> > > -t parameter. This does not seem to make sense to me. Is it correct?
> > > Does it do anything?
> > >
> > > My thinking is that we should just remove the -t from that synopsis.
> >
> > Well, Peter added it, but register already had the -w parameter, so
> > either register needs both -t and -w, or it needs neither of them. I
> > don't know which is true.
>
> Humm, in pgwin32_CommandLine I don't see any reference to -t but -w is
> there. So either
>
> a) the bug is that somebody forgot to add -t to pgwin32_CommandLine
> b) the bug is that -t was added to the synopsis, or
> c) I'm full of it because of an untold reason.

Yes, the bug was "a" and I am responsible. I didn't realize pg_ctl
register stores all its arguments. Patch attached and applied. The
SGML documentation is now accurate.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/rtmp/diff text/x-diff 2.3 KB