BUG #3770: Follow up: Fail to make bcc32.mak for libpq

The following bug has been logged online:

Bug reference: 3770
Logged by: CN
Email address: cnliou9(at)fastmail(dot)fm
PostgreSQL version: 8.3beta3
Operating system: Win 98
Description: Follow up: Fail to make bcc32.mak for libpq
Details:

I manually copied ~/src/include/port/win32.h to
~/src/include/pg_config_os.h. BCC55 make produces different errors:
--------------
bcc32.exe
-I\borland\bcc55\include;..\..\include;..\..\include\port\win32;..\..\includ
e\port\win32_msvc;..\..\port -n".\Release" -WD -c
-DFRONTEND;NDEBUG;WIN32;_WINDOWS -tWM -a8 -X -w-use -w-par -w-pia -w-csu
-w-aus -w-ccc -O -Oi -OS -DNDEBUG fe-auth.c
Borland C++ 5.5.1 for Win32 Copyright (c) 1993, 2000 Borland
fe-auth.c:
Warning W8017 ..\..\include\getaddrinfo.h 47: Redefinition of
'WSATYPE_NOT_FOUND' is not identical
Error E2141 libpq-int.h 532: Declaration syntax error
Error E2141 libpq-int.h 533: Declaration syntax error
*** 2 errors in Compile ***

** error 1 ** deleting ".\Release\fe-auth.obj"

CN wrote:
>
> The following bug has been logged online:
>
> Bug reference: 3770
> Logged by: CN
> Email address: cnliou9(at)fastmail(dot)fm
> PostgreSQL version: 8.3beta3
> Operating system: Win 98
> Description: Follow up: Fail to make bcc32.mak for libpq
> Details:
>
> I manually copied ~/src/include/port/win32.h to
> ~/src/include/pg_config_os.h. BCC55 make produces different errors:

OK, you did what my patch did.

> --------------
> bcc32.exe
> -I\borland\bcc55\include;..\..\include;..\..\include\port\win32;..\..\includ
> e\port\win32_msvc;..\..\port -n".\Release" -WD -c
> -DFRONTEND;NDEBUG;WIN32;_WINDOWS -tWM -a8 -X -w-use -w-par -w-pia -w-csu
> -w-aus -w-ccc -O -Oi -OS -DNDEBUG fe-auth.c
> Borland C++ 5.5.1 for Win32 Copyright (c) 1993, 2000 Borland
> fe-auth.c:
> Warning W8017 ..\..\include\getaddrinfo.h 47: Redefinition of
> 'WSATYPE_NOT_FOUND' is not identical
> Error E2141 libpq-int.h 532: Declaration syntax error
> Error E2141 libpq-int.h 533: Declaration syntax error
> *** 2 errors in Compile ***
>
> ** error 1 ** deleting ".\Release\fe-auth.obj"

Uh, try the attached, applied patch. Seems you already have
WSATYPE_NOT_FOUND defined in BCC.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +