| Lists: | pgsql-hackers |
|---|
| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Valgrind and shared_buffers (Was: Restore-reliability mode) |
| Date: | 2015-11-04 02:59:46 |
| Message-ID: | CAM3SWZR3XB5Hw_bkHkAKm_HTQRMPRzPH4bKFicPUFriZiSWa0w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, Jul 27, 2015 at 7:12 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> I only tried a few tests, for lack of time, and it didn't produce any.
> (To verify that the whole thing was working properly, I reduced the
> range of memory made available during PinBuffer and that resulted in a
> crash immediately). I am not really familiar with valgrind TBH and just
> copied a recipe to run postmaster under it, so if someone with more
> valgrind-fu could verify this, it would be great.
>
>
> This part:
>
>> > > > Under CLOBBER_FREED_MEMORY, wipe a shared buffer when its
>> > > > global pin count falls to zero.
>
> can be done without any valgrind, I think. Any takers?
It seems like this didn't go anywhere. Any chance that you'll find the
time to work on this soon?
--
Peter Geoghegan
| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Valgrind and shared_buffers (Was: Restore-reliability mode) |
| Date: | 2015-11-04 12:54:10 |
| Message-ID: | 20151104125410.GQ6104@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Peter Geoghegan wrote:
> On Mon, Jul 27, 2015 at 7:12 AM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
> > I only tried a few tests, for lack of time, and it didn't produce any.
> > (To verify that the whole thing was working properly, I reduced the
> > range of memory made available during PinBuffer and that resulted in a
> > crash immediately). I am not really familiar with valgrind TBH and just
> > copied a recipe to run postmaster under it, so if someone with more
> > valgrind-fu could verify this, it would be great.
> >
> >
> > This part:
> >
> >> > > > Under CLOBBER_FREED_MEMORY, wipe a shared buffer when its
> >> > > > global pin count falls to zero.
> >
> > can be done without any valgrind, I think. Any takers?
>
> It seems like this didn't go anywhere. Any chance that you'll find the
> time to work on this soon?
No. How about you? If you or someone else with more valgrind
familiarity than me look it over and think it's correct, I can push it.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services