Re: bug report: 7.4beta3 pg_ctl log handling

Lists: pgsql-bugs
From: Arguile <arguile(at)lucentstudios(dot)com>
To: pgsql-bugs(at)postgresql(dot)org
Subject: bug report: 7.4beta3 pg_ctl log handling
Date: 2003-10-02 04:39:45
Message-ID: 1065069586.26654.78.camel@broadswd
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

Simplest case to test is:

pg_ctl start -D /valid/db/dir -l /invalid/dir
pg_ctl: /invalid/dir: No such file or directory
postmaster successfully started

Postmaster hasn't started and the error could probably use some work.

Perhaps some more tests after line 340 of pg_ctl would be appropriate.
Something along the lines of (perlish pseudocode):

if ( -w $logfile || ( -w `dirname $logfile` )

Should it also test -O to ensure ownership if the file does exist? I'll
brush up on my sh and submit a patch if requested.


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Arguile <arguile(at)lucentstudios(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: bug report: 7.4beta3 pg_ctl log handling
Date: 2003-10-02 04:54:40
Message-ID: 20577.1065070480@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

Arguile <arguile(at)lucentstudios(dot)com> writes:
> Simplest case to test is:
> pg_ctl start -D /valid/db/dir -l /invalid/dir
> pg_ctl: /invalid/dir: No such file or directory
> postmaster successfully started

> Postmaster hasn't started and the error could probably use some work.

If you don't specify -w then pg_ctl only launches the postmaster,
it does not wait around to see if the postmaster really fired up
sucessfully. If there's a bug here, it's only that -w isn't the
default behavior.

regards, tom lane


From: Arguile <arguile(at)lucentstudios(dot)com>
To: pgsql-bugs(at)postgresql(dot)org
Subject: Re: bug report: 7.4beta3 pg_ctl log handling
Date: 2003-10-02 05:02:46
Message-ID: 1065070969.26654.82.camel@broadswd
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On Thu, 2003-10-02 at 00:54, Tom Lane wrote:
> Arguile <arguile(at)lucentstudios(dot)com> writes:
> > Simplest case to test is:
> > pg_ctl start -D /valid/db/dir -l /invalid/dir
> > pg_ctl: /invalid/dir: No such file or directory
> > postmaster successfully started
>
> > Postmaster hasn't started and the error could probably use some work.
>
> If you don't specify -w then pg_ctl only launches the postmaster,
> it does not wait around to see if the postmaster really fired up
> sucessfully. If there's a bug here, it's only that -w isn't the
> default behavior.

Oops. You can tell how often I start Pg by hand ;). Sorry for the
bother.