Re: Quitting the thes

Hi all,

Here my first patch for postgres. Starting by an easy thing, I correct
the duplicated "the the" strings from comments on some files.

- src/backend/executor/execExpr.c
- src/include/c.h
- src/include/jit/llvmjit_emit.h
- src/include/nodes/execnodes.h
- src/include/replication/logical.h

Any feedback are welcome!

Thanks a lot,

On Mon, May 13, 2019 at 04:52:15PM -0300, Stephen Amell wrote:
> Here my first patch for postgres. Starting by an easy thing, I correct the
> duplicated "the the" strings from comments on some files.

Welcome!

> - src/backend/executor/execExpr.c
> - src/include/c.h
> - src/include/jit/llvmjit_emit.h
> - src/include/nodes/execnodes.h
> - src/include/replication/logical.h
>
> Any feedback are welcome!

Thanks, committed. I have noticed an extra one in reorderbuffer.c.

If you get interested in more areas of the code, there is plently of
small work items which can be reviewed or worked on.

We have on the wiki a manual about how to submit a patch:
https://wiki.postgresql.org/wiki/Submitting_a_Patch

Patches go through a dedicated commit fest app, and it has many small
fishes which can be worked on:
https://commitfest.postgresql.org/23/
You could get more familiar with some areas of the code this way.

Thanks,
--
Michael

Hi all

(CC'ing 'Last-Translator' addresses)

I noticed a few duplicated words in the .po files. Some of these are
obviously false positives.

This command reports them with color highlighting:
$ git grep '\<\([a-z_ ]\+\)\> \<\1\>' -- *.po

src/backend/po/de.po:msgstr "Wenn der Planer schätzt, dass zu wenige Tabellenseiten gelesen werden werden um diesen Wert zu erreichen, dann wird kein paralleler Scan in Erwägung gezogen werden."
src/backend/po/de.po:msgstr "Wenn der Planer schätzt, dass zu wenige Indexseiten gelesen werden werden um diesen Wert zu erreichen, dann wird kein paralleler Scan in Erwägung gezogen werden."
src/backend/po/de.po:msgstr "Setzt den vom Planer geschätzten Anteil der Cursor-Zeilen, die ausgelesen werden werden."
src/backend/po/fr.po:msgstr "l'extension « %s » n'a pas de script d'installation ou de chemin de de mise à jour pour la version « %s »"
src/backend/po/fr.po:msgstr "les fonctions in_range btree doivent doivent retourner un booléen"
src/backend/po/fr.po:msgstr "la relation référencée « %s » n'est ni une table ni une table distante"
src/backend/po/fr.po:msgstr "la relation héritée « %s » n'est ni une table ni une table distante"
src/backend/po/fr.po:"l'option DISABLE_PAGE_SKIPPING de la commande VACUUM ne pas pas être utilisée\n"
src/backend/po/fr.po:"Vous pourriez avoir avoir besoin d'ajouter des conversions de type explicites."
src/backend/po/fr.po:msgstr "symbole « %c » invalide invalide lors du décodage de la séquence en base64"
src/backend/po/fr.po:msgstr "La chaîne des des guillements doubles non fermés."
src/backend/po/id.po:msgstr "sambungan terputus saat COPY ke stdout stdout"
src/backend/po/id.po:msgstr "Gunakan 'quoted CSV field' untuk menyatakan baris baris baru"
src/backend/po/id.po:msgstr "file konfigurasi « %s » terdapat errors ; tidak tidak terpengaruh applied"
src/backend/po/it.po:msgstr "le protezioni di wraparound dei membri MultiXact sono disabilitate perché il il MultiXact più vecchio che abbia ricevuto un checkpoint %u non esiste sul disco"
src/backend/po/it.po:msgstr "La rilevazione di un errore in una somma di controllo di solito fa generare a PostgreSQL un errore che fa abortire la transazione corrente. Impostare ignore_checksum_failure a \"true\" fa sì che il sistema ignori l'errore (che viene riportato come un avviso), consentendo al processo di continuare. Questo comportamento potrebbe causare crash o altri problemi gravi. Ha effetto solo se se somme di controllo sono abilitate."
src/backend/po/sv.po:msgid "tid (%u, %u) is not valid for relation for relation \"%s\""
src/backend/po/tr.po:msgstr "\"%2$s\" kullanarak kullanarak PID %1$d olan başka bir istemci süreci çalışmakta mıdır?"
src/backend/po/tr.po:msgstr "\"%2$s\" kullanarak kullanarak PID %1$d olan başka bir sunucu çalışmakta mıdır?"
src/bin/initdb/po/cs.po:msgstr "Spusťte znovu %s s přepínačem -E.\n"
src/bin/initdb/po/cs.po:"Pusťte znovu %s s jiným nastavením locale.\n"
src/bin/initdb/po/tr.po:"kaldırın, ya boşaltın ya da ya da %s 'i \n"
src/bin/pg_basebackup/po/de.po:"Optionen, die die Ausgabe kontrollieren:\n"
src/bin/pg_basebackup/po/tr.po:msgstr "%s: --no-slot slot adıyla birlikte kullanılamaz\n"
src/bin/pg_dump/po/de.po:"Optionen die die Wiederherstellung kontrollieren:\n"
src/bin/pg_resetwal/po/it.po:msgstr " (zero in uno dei dei valori vuol dire nessun cambiamento)\n"
src/bin/psql/po/de.po:msgstr "ändert den Eigentümer der der Rolle gehörenden Datenbankobjekte"
src/bin/scripts/po/pl.po:msgstr " -t, --timeout=SEKUNDY sekundy oczekiwania podczas podczas próby połączenia, 0 wyłącza (domyślnie: %s)\n"
src/interfaces/ecpg/ecpglib/po/pl.po:msgstr "zmienna nie ma typu typu numeric, linia %d"
src/interfaces/ecpg/ecpglib/po/pl.po:msgstr "zmienna nie ma typu typu character, linia %d"
src/interfaces/libpq/po/fr.po:msgstr "mot de passe récupéré dans le fichier fichier « %s »\n"
src/interfaces/libpq/po/it.po:msgstr "non è stato possibile possibile ottenere il certificato: %s\n"

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On 2019-May-14, Michael Paquier wrote:

> Thanks, committed. I have noticed an extra one in reorderbuffer.c.

Some grepping found a bit more; patch attached.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Le mer. 12 juin 2019 à 20:45, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> a
écrit :

> On 2019-May-14, Michael Paquier wrote:
>
> > Thanks, committed. I have noticed an extra one in reorderbuffer.c.
>
> Some grepping found a bit more; patch attached.
>
>
Thanks a lot, this is very good. I've got some fixes to do :)

--
Guillaume.

On Wed, Jun 12, 2019 at 02:45:27PM -0400, Alvaro Herrera wrote:
> Some grepping found a bit more; patch attached.

Indeed. There were much more. I just got to look with stuff like
that:
find . -name "*.c" | xargs egrep "(\b[a-zA-Z]+) \1\b"

But I did not find any more spots. Indentation is incorrect in
test_integerset.c.
--
Michael

On 2019-Jun-13, Michael Paquier wrote:

> On Wed, Jun 12, 2019 at 02:45:27PM -0400, Alvaro Herrera wrote:
> > Some grepping found a bit more; patch attached.
>
> Indeed. There were much more. I just got to look with stuff like
> that:
> find . -name "*.c" | xargs egrep "(\b[a-zA-Z]+) \1\b"

This is what I used:
git grep '\<\([a-z_ ]\+\)\> \<\1\>'

> But I did not find any more spots. Indentation is incorrect in
> test_integerset.c.

Indeed ... fixed.

Thanks for looking,

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On 2019-06-12 20:40, Alvaro Herrera wrote:
> I noticed a few duplicated words in the .po files. Some of these are
> obviously false positives.

The "de" ones were all correct as is, but some of the ones in other
languages do indeed look like typos.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services