Re: [Pgbuildfarm-members] latest commit to use warnings produces

The latest commit to turn on warnings produces warnings which makes
running it from cron send me useless messages.

Appears $verbose isn't initialized correctly.

Use of uninitialized value in numeric gt (>) at
/home/pgfarm/conf/client-code/run_build.pl line 938.
Use of uninitialized value in numeric gt (>) at
/home/pgfarm/conf/client-code/run_build.pl line 973.
Use of uninitialized value in numeric gt (>) at
/home/pgfarm/conf/client-code/run_build.pl line 829.
Use of uninitialized value in numeric gt (>) at
/home/pgfarm/conf/client-code/run_build.pl line 607.

and many more.

Kris Jurka

please see if this patch fixes it:

Index: run_build.pl
===================================================================
RCS file: /cvsroot/pgbuildfarm/client-code/run_build.pl,v
retrieving revision 1.54
diff -c -u -r1.54 run_build.pl
cvs diff: conflicting specifications of output style
--- run_build.pl 19 Dec 2005 19:37:21 -0000 1.54
+++ run_build.pl 21 Dec 2005 18:53:06 -0000
@@ -113,6 +113,7 @@
if ($from_source && $from_source_clean);

$verbose=1 if (defined($verbose) && $verbose==0);
+$verbose ||= 0; # stop complaints about undefined var in numeric comparison

use vars qw($branch);
my $explicit_branch = shift;

thanks

andrew

Kris Jurka said:
>
> The latest commit to turn on warnings produces warnings which makes
> running it from cron send me useless messages.
>
> Appears $verbose isn't initialized correctly.
>
> Use of uninitialized value in numeric gt (>) at
> /home/pgfarm/conf/client-code/run_build.pl line 938.
> Use of uninitialized value in numeric gt (>) at
> /home/pgfarm/conf/client-code/run_build.pl line 973.
> Use of uninitialized value in numeric gt (>) at
> /home/pgfarm/conf/client-code/run_build.pl line 829.
> Use of uninitialized value in numeric gt (>) at
> /home/pgfarm/conf/client-code/run_build.pl line 607.
>
> and many more.
>
> Kris Jurka
> _______________________________________________
> Pgbuildfarm-members mailing list
> Pgbuildfarm-members(at)pgfoundry(dot)org
> http://pgfoundry.org/mailman/listinfo/pgbuildfarm-members

On Wed, 21 Dec 2005, Andrew Dunstan wrote:

>
> please see if this patch fixes it:

Yes, it does.

Kris Jurka