Minor update on pg_hba documentation

Lists: pgsql-bugs
From: SAS <sas(dot)postgresql(at)gmail(dot)com>
To: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Minor update on pg_hba documentation
Date: 2024-06-04 15:22:22
Message-ID: 44662001-54c4-4bfd-be93-35e01ca25fa1@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

Hi,

I wonder if there is an extra word that should be suppressed on the PG 16
client-auth.sgml file.

In the example for the regex on database name, the TYPE is "local" and contains
the word "localhost" for ADDRESS. Shouldn't it be omitted ?

Best regards,

--
Dr Stéphane Schildknecht
Contact régional PostgreSQL pour l'Europe francophone
+33 617 11 37 42

Attachment Content-Type Size
client-auth.sgml.patch text/x-patch 661 bytes

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: SAS <sas(dot)postgresql(at)gmail(dot)com>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: Minor update on pg_hba documentation
Date: 2024-06-05 03:30:30
Message-ID: CAKFQuwYheUVBWubBcsfNEzn2stZPDL3m4yDmxjX+wJXQ=uJvPQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On Tue, Jun 4, 2024 at 8:22 AM SAS <sas(dot)postgresql(at)gmail(dot)com> wrote:

> In the example for the regex on database name, the TYPE is "local" and
> contains the word "localhost" for ADDRESS. Shouldn't it be omitted ?
>
I'd suggest changing local to host and leave the address alone. Having a
local example at that spot seems odd since everything around it is host and
the text ties them together.

David J.


From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: SAS <sas(dot)postgresql(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: Minor update on pg_hba documentation
Date: 2024-06-05 06:33:02
Message-ID: ZmAGnrtz_U75bacy@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On Tue, Jun 04, 2024 at 08:30:30PM -0700, David G. Johnston wrote:
> On Tue, Jun 4, 2024 at 8:22 AM SAS <sas(dot)postgresql(at)gmail(dot)com> wrote:
>
> > In the example for the regex on database name, the TYPE is "local" and
> > contains the word "localhost" for ADDRESS. Shouldn't it be omitted ?
> >
> I'd suggest changing local to host and leave the address alone. Having a
> local example at that spot seems odd since everything around it is host and
> the text ties them together.

My fault on this one. My intention was likely to use "host". I'll go
fix it this way. Nice catch.
--
Michael


From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: SAS <sas(dot)postgresql(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: Minor update on pg_hba documentation
Date: 2024-06-05 11:19:42
Message-ID: ZmBJzmIokllatneQ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On Wed, Jun 05, 2024 at 03:33:02PM +0900, Michael Paquier wrote:
> My fault on this one. My intention was likely to use "host". I'll go
> fix it this way. Nice catch.

On top of using David's suggestion, I have also tweaked the format of
this HBA entry to make it aligned with the rest.
--
Michael