| Lists: | pgsql-patches |
|---|
| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | <pgsql-patches(at)postgresql(dot)org> |
| Subject: | vcbuild small fix for plperl |
| Date: | 2006-11-21 17:45:12 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCEA0FD45@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Typo in the changes to plperl - uses wrong dir, and had a missing slash.
Also fixes error checking for xsubpp - it was broken in a way that hid
the problem above when run more than once (which is the normal case when
developing).
//Magnus
| Attachment | Content-Type | Size |
|---|---|---|
| vcbuild_plperl.diff | application/octet-stream | 1.7 KB |
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Magnus Hagander <mha(at)sollentuna(dot)net> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: vcbuild small fix for plperl |
| Date: | 2006-11-21 17:51:17 |
| Message-ID: | 45633C95.7000407@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Magnus Hagander wrote:
> Typo in the changes to plperl - uses wrong dir, and had a missing slash.
>
> Also fixes error checking for xsubpp - it was broken in a way that hid
> the problem above when run more than once (which is the normal case when
> developing).
>
>
>
I have just noticed that this file appears to have the perl version
hardcoded (perl58.lib). That doesn't seem sensible ... can it be avoided?
cheers
andrew
| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Magnus Hagander <mha(at)sollentuna(dot)net> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: vcbuild small fix for plperl |
| Date: | 2006-11-21 17:54:41 |
| Message-ID: | 1164131681.23622.131.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
On Tue, 2006-11-21 at 18:45 +0100, Magnus Hagander wrote:
> Typo in the changes to plperl - uses wrong dir, and had a missing slash.
Applied, thanks.
-Neil
| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
| Cc: | <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: vcbuild small fix for plperl |
| Date: | 2006-11-21 18:01:17 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCEA0FD46@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
> > Typo in the changes to plperl - uses wrong dir, and had a
> missing slash.
> >
> > Also fixes error checking for xsubpp - it was broken in a
> way that hid
> > the problem above when run more than once (which is the normal case
> > when developing).
> >
>
> I have just noticed that this file appears to have the perl
> version hardcoded (perl58.lib). That doesn't seem sensible
> ... can it be avoided?
It's definitly on my long-term TODO.
//Magnus