AllocSetStats uses fprintf instead of elog

Lists: pgsql-hackers
From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: AllocSetStats uses fprintf instead of elog
Date: 2007-11-16 13:46:13
Message-ID: 473D9F25.7020906@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Function AllocSetStats uses fprintf instead of standard logging method.
Is there any reason for it? If not I will rewrite it to use
elog(NOTICE,..) instead.

Zdenek


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: AllocSetStats uses fprintf instead of elog
Date: 2007-11-16 16:30:13
Message-ID: 13562.1195230613@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> Function AllocSetStats uses fprintf instead of standard logging method.
> Is there any reason for it?

Yes: it's typically called in zero-free-memory situations, and we don't
want to depend on elog() succeeding to be able to find out what happened.

regards, tom lane