Re: pgsql: New versions of mingw have gettimeofday(), so add an autoconf

Log Message:
-----------
New versions of mingw have gettimeofday(), so add an autoconf test
for this.

Modified Files:
--------------
pgsql:
configure (r1.565 -> r1.566)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/configure?r1=1.565&r2=1.566)
configure.in (r1.531 -> r1.532)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/configure.in?r1=1.531&r2=1.532)
pgsql/src/include:
pg_config.h.in (r1.124 -> r1.125)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/pg_config.h.in?r1=1.124&r2=1.125)
port.h (r1.113 -> r1.114)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/port.h?r1=1.113&r2=1.114)
pgsql/src/include/port:
win32.h (r1.77 -> r1.78)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/port/win32.h?r1=1.77&r2=1.78)

Magnus Hagander wrote:
> Log Message:
> -----------
> New versions of mingw have gettimeofday(), so add an autoconf test
> for this.
>

Can we backport this fix? I'm trying to setup a new windows build
environment and this is currently halting my progress for back branches.

Kris Jurka

On Mon, 2007-11-19 at 02:50 -0700, Kris Jurka wrote:
> Magnus Hagander wrote:
> > Log Message:
> > -----------
> > New versions of mingw have gettimeofday(), so add an autoconf test
> > for this.
> >
>
> Can we backport this fix? I'm trying to setup a new windows build
> environment and this is currently halting my progress for back branches.

Technically, it's fairly easy. And given that it's been working for a
couple of betas of 8.3, it seems it should be safe. OTOH, the official
build for 8.3 doesn't use it, so binary testers haven't seen it. But any
issues should've been build issues rather than runtime ones, I think.

So yeah, it would be reasonably easy to do, and probably a good idea.
Anybody think we shouldn't?

//Magnus

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Mon, 2007-11-19 at 02:50 -0700, Kris Jurka wrote:
>> Can we backport this fix? I'm trying to setup a new windows build
>> environment and this is currently halting my progress for back branches.

> Technically, it's fairly easy. And given that it's been working for a
> couple of betas of 8.3, it seems it should be safe. OTOH, the official
> build for 8.3 doesn't use it, so binary testers haven't seen it. But any
> issues should've been build issues rather than runtime ones, I think.

> So yeah, it would be reasonably easy to do, and probably a good idea.
> Anybody think we shouldn't?

Given that we're abandoning support for 8.0 and 8.1 on Windows,
I'd say +1 for fixing 8.2, but not for any older branches.

regards, tom lane

On Wed, Nov 21, 2007 at 03:33:53PM -0500, Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > On Mon, 2007-11-19 at 02:50 -0700, Kris Jurka wrote:
> >> Can we backport this fix? I'm trying to setup a new windows build
> >> environment and this is currently halting my progress for back branches.
>
> > Technically, it's fairly easy. And given that it's been working for a
> > couple of betas of 8.3, it seems it should be safe. OTOH, the official
> > build for 8.3 doesn't use it, so binary testers haven't seen it. But any
> > issues should've been build issues rather than runtime ones, I think.
>
> > So yeah, it would be reasonably easy to do, and probably a good idea.
> > Anybody think we shouldn't?
>
> Given that we're abandoning support for 8.0 and 8.1 on Windows,
> I'd say +1 for fixing 8.2, but not for any older branches.

Done.

//Magnus