pgbench doc typos

Lists: Postg토토 꽁 머니SQL : Postg토토 꽁 머니SQL 메일 링리스트 : 2016-01-12 이후 PGSQL-DOCS 15:27pgsql-hackers
From: Erik Rijkers <er(at)xs4all(dot)nl>
To: pgsql-docs(at)postgresql(dot)org
Subject: pgbench doc typos
Date: 2016-01-12 15:27:59
Message-ID: 486824e5bbd6eef5061bcfc370c666a1@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: Postg토토 꽁 머니SQL : Postg토토 꽁 머니SQL 메일 링리스트 : 2016-01-12 이후 PGSQL-DOCS 15:27 pgsql-hackers

2 typo's in doc/src/sgml/ref/pgbench.sgml

Another (separate) small thing:

I did not understand this sentence:

"Notice that while the plain (unaggregated) log file contains index
of the custom script files, the aggregated log does not."

"contains index"? what does that mean?

Not understanding, I have not changed it. I think it could be made more
clear.

thanks,

Erik Rijkers

Attachment Content-Type Size
pgbench.sgml.diff text/x-diff 754 bytes

From: Erik Rijkers <er(at)xs4all(dot)nl>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Fwd: [DOCS] pgbench doc typos
Date: 2016-01-27 11:06:17
Message-ID: a454b7d074ef71cb9da9350fc4ae29e8@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-docs pgsql-hackers

Two trivial changes to doc/src/sgml/ref/pgbench.sgml

Erik Rijkers


From: Erik Rijkers <er(at)xs4all(dot)nl>
To: pgsql-hackers(at)postgresql(dot)org
Cc: pgsql-hackers-owner(at)postgresql(dot)org
Subject: Re: Fwd: [DOCS] pgbench doc typos
Date: 2016-01-27 11:32:34
Message-ID: 661df7c9f9634bb7116be15e9a8638e8@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-docs pgsql-hackers

On 2016-01-27 11:06, Erik Rijkers wrote:
> Two trivial changes to doc/src/sgml/ref/pgbench.sgml

Sorry - now attached.

Erik Rijkers

Attachment Content-Type Size
pgbench.sgml.diff text/x-diff 758 bytes

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org
Subject: Re: Fwd: [DOCS] pgbench doc typos
Date: 2016-02-01 13:08:09
Message-ID: CAHGQGwHWjhquD1fsXTnYTKCDnN+wCuFO5_irfN0UTq9fexLKJQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-docs pgsql-hackers

On Wed, Jan 27, 2016 at 8:32 PM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
> On 2016-01-27 11:06, Erik Rijkers wrote:
>>
>> Two trivial changes to doc/src/sgml/ref/pgbench.sgml

- Here is example outputs:
+ Here is example output:

"Here are example outputs" is better?
In 9.4 document, that description was used for the example outputs
of per-transaction logging.

> I did not understand this sentence:
>
> "Notice that while the plain (unaggregated) log file contains index
> of the custom script files, the aggregated log does not."
>
> "contains index"? what does that mean?
>
> Not understanding, I have not changed it. I think it could be made more
> clear.

What about the following?

--------------------
When multiple custom script files are specified with -f option,
while the plain (unaggregated) log file contains <lateral>file_no</> field
which identifies which script file is used, the aggregated log does not.
Therefore if you need per script data, <option>--aggregate-interval</> option
should not be specified and you need to aggregate the data on your own
from the plain log file.
--------------------

BTW, I found another problem in pgbench.sgml. skipped_transactions is
documented as the last field of the plain log, but the format of the log
doesn't include that as follows.

client_id transaction_no time file_no time_epoch time_us [schedule_lag]

Regards,

--
Fujii Masao


From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Erik Rijkers <er(at)xs4all(dot)nl>, pgsql-docs(at)postgresql(dot)org
Subject: Re: pgbench doc typos
Date: 2016-04-23 18:55:21
Message-ID: 571BC519.3020208@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-docs pgsql-hackers

On 01/12/2016 10:27 AM, Erik Rijkers wrote:
> 2 typo's in doc/src/sgml/ref/pgbench.sgml
>
>
> Another (separate) small thing:
>
> I did not understand this sentence:
>
> "Notice that while the plain (unaggregated) log file contains index
> of the custom script files, the aggregated log does not."
>
> "contains index"? what does that mean?
>
> Not understanding, I have not changed it. I think it could be made more
> clear.

fixed and backpatched