| Lists: | pgsql-hackers |
|---|
| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Incorrect path in header comment identification |
| Date: | 2018-05-14 09:45:19 |
| Message-ID: | 5689003B-6A71-464F-B199-A3132787BA65@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Commit ba11258ccb which renamed inet_net_ntop.c in src/backend/utils/adt, and
introduced inet_net_ntop.c in src/ports didn’t update the IDENTIFICATION lines
in the header comments. Is there a reason to keep the old locations rather
than updating to the actual locations as per the below trivial diff?
cheers ./daniel
diff --git a/src/backend/utils/adt/inet_cidr_ntop.c b/src/backend/utils/adt/inet_cidr_ntop.c
index 30b3673789..5a30df16e5 100644
--- a/src/backend/utils/adt/inet_cidr_ntop.c
+++ b/src/backend/utils/adt/inet_cidr_ntop.c
@@ -14,7 +14,7 @@
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
* OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*
- * src/backend/utils/adt/inet_net_ntop.c
+ * src/backend/utils/adt/inet_cidr_ntop.c
*/
#if defined(LIBC_SCCS) && !defined(lint)
diff --git a/src/port/inet_net_ntop.c b/src/port/inet_net_ntop.c
index f27fda96ca..90dfeed42d 100644
--- a/src/port/inet_net_ntop.c
+++ b/src/port/inet_net_ntop.c
@@ -14,7 +14,7 @@
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
* OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*
- * src/backend/utils/adt/inet_net_ntop.c
+ * src/port/inet_net_ntop.c
*/
#if defined(LIBC_SCCS) && !defined(lint)
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Incorrect path in header comment identification |
| Date: | 2018-05-14 17:00:53 |
| Message-ID: | CABUevEzg1puqB=V9WJDEJiT49tMvYux=wNCzqpYy38VaV8AtXg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, May 14, 2018 at 11:45 AM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> Commit ba11258ccb which renamed inet_net_ntop.c in src/backend/utils/adt,
> and
> introduced inet_net_ntop.c in src/ports didn’t update the IDENTIFICATION
> lines
> in the header comments. Is there a reason to keep the old locations rather
> than updating to the actual locations as per the below trivial diff?
>
> cheers ./daniel
>
> diff --git a/src/backend/utils/adt/inet_cidr_ntop.c
> b/src/backend/utils/adt/inet_cidr_ntop.c
> index 30b3673789..5a30df16e5 100644
> --- a/src/backend/utils/adt/inet_cidr_ntop.c
> +++ b/src/backend/utils/adt/inet_cidr_ntop.c
> @@ -14,7 +14,7 @@
> * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
> * OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
> *
> - * src/backend/utils/adt/inet_net_ntop.c
> + * src/backend/utils/adt/inet_cidr_ntop.c
> */
>
> #if defined(LIBC_SCCS) && !defined(lint)
> diff --git a/src/port/inet_net_ntop.c b/src/port/inet_net_ntop.c
> index f27fda96ca..90dfeed42d 100644
> --- a/src/port/inet_net_ntop.c
> +++ b/src/port/inet_net_ntop.c
> @@ -14,7 +14,7 @@
> * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
> * OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
> *
> - * src/backend/utils/adt/inet_net_ntop.c
> + * src/port/inet_net_ntop.c
> */
>
> #if defined(LIBC_SCCS) && !defined(lint)
>
Failed to get the actual patch to apply (probably cut/paste issue from it
being inline), but since the changes were trivial, just made those.
Thanks, applied.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>