| Lists: | pgsql-hackers-win32pgsql-patches |
|---|
| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | <pgsql-patches(at)postgresql(dot)org>, "pgsql-hackers-win32" <pgsql-hackers-win32(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] Updated win32 readdir patch |
| Date: | 2004-02-08 22:25:22 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCE34B173@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers-win32 pgsql-patches |
>> Here is an updated version of the win32 readdir patch.
>
>> 1) Now puts in exactly the same change as the current-cvs mingw code
>> does. (see
>>
>>http://cvs.sourceforge.net/viewcvs.py/mingw/runtime/mingwex/dir
ent.c?r1=3D
>> 1.3&r2=3D1.4, second part of the patch).
> I don't really agree with cluttering our code with temporary
workarounds
>for a mingw bug.
Fine by me, as long as we still keep it on the win32 page. It *is*
required to build on win32 (or rather - not to build, but if you build
without it, you will get a runtime failure).
AFAIK we have no idea when the new mingw will actually be out, but if
it's out before the postgresql version with win32, then we're fine
without it. If not, we can discuss at that time if we want it
temporarily applied or keep it as a temporary patch (since it might at
that point make a big difference for people downloading the distro and
thinking it would work out of the box).
//Magnus
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <mha(at)sollentuna(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org, pgsql-hackers-win32 <pgsql-hackers-win32(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] Updated win32 readdir patch |
| Date: | 2004-02-09 16:52:13 |
| Message-ID: | 200402091652.i19GqDD13253@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers-win32 pgsql-patches |
Magnus Hagander wrote:
> >> Here is an updated version of the win32 readdir patch.
> >
> >> 1) Now puts in exactly the same change as the current-cvs mingw code
> >> does. (see
> >>
> >>http://cvs.sourceforge.net/viewcvs.py/mingw/runtime/mingwex/dir
> ent.c?r1=3D
> >> 1.3&r2=3D1.4, second part of the patch).
>
> > I don't really agree with cluttering our code with temporary
> workarounds
> >for a mingw bug.
>
> Fine by me, as long as we still keep it on the win32 page. It *is*
> required to build on win32 (or rather - not to build, but if you build
> without it, you will get a runtime failure).
>
> AFAIK we have no idea when the new mingw will actually be out, but if
> it's out before the postgresql version with win32, then we're fine
> without it. If not, we can discuss at that time if we want it
> temporarily applied or keep it as a temporary patch (since it might at
> that point make a big difference for people downloading the distro and
> thinking it would work out of the box).
I suggest we apply the patch, and add a TODO to remove it once we get an
MinGW update that fixes it.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073