| Lists: | pgsql-patches |
|---|
| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | float8 functions |
| Date: | 2002-10-04 16:10:46 |
| Message-ID: | 871y76b2wp.fsf@mailbox.samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
This patch adds some missing functions for float8 math operations,
specifically ceil(), floor(), and sign(). There may be other functions
that need to be added, but this is a start. I've included some simple
regression tests.
Unless anyone sees a problem, please add this to the 7.4 queue.
Cheers,
Neil
--
Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC
| Attachment | Content-Type | Size |
|---|---|---|
| float8-funcs.patch | text/x-patch | 8.1 KB |
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: float8 functions |
| Date: | 2002-10-14 04:33:50 |
| Message-ID: | 200210140433.g9E4XoO11989@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
This has been saved for the 7.4 release:
http://candle.pha.pa.us/cgi-bin/pgpatches2
---------------------------------------------------------------------------
Neil Conway wrote:
> This patch adds some missing functions for float8 math operations,
> specifically ceil(), floor(), and sign(). There may be other functions
> that need to be added, but this is a start. I've included some simple
> regression tests.
>
> Unless anyone sees a problem, please add this to the 7.4 queue.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: float8 functions |
| Date: | 2002-10-15 04:56:50 |
| Message-ID: | 87adlgs3jh.fsf@mailbox.samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Neil Conway <neilc(at)samurai(dot)com> writes:
> Unless anyone sees a problem, please add this to the 7.4 queue.
Since it appears that we're requiring an initdb for beta3 anyway,
would this be appropriate for 7.3 instead?
IMHO, yes -- feature regressions are not desirable, particularly ones
that could bite people while upgrading. And the fix is not very
complex...
Cheers,
Neil
--
Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: float8 functions |
| Date: | 2002-10-15 21:43:01 |
| Message-ID: | 200210152143.g9FLh1Y15555@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Neil Conway wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
> > Unless anyone sees a problem, please add this to the 7.4 queue.
>
> Since it appears that we're requiring an initdb for beta3 anyway,
> would this be appropriate for 7.3 instead?
>
> IMHO, yes -- feature regressions are not desirable, particularly ones
> that could bite people while upgrading. And the fix is not very
> complex...
Yes, it is a fix so I will move it to the main patches queue.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: float8 functions |
| Date: | 2002-10-15 21:44:02 |
| Message-ID: | 200210152144.g9FLi2715742@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Neil Conway wrote:
> This patch adds some missing functions for float8 math operations,
> specifically ceil(), floor(), and sign(). There may be other functions
> that need to be added, but this is a start. I've included some simple
> regression tests.
>
> Unless anyone sees a problem, please add this to the 7.4 queue.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: float8 functions |
| Date: | 2002-10-19 02:07:54 |
| Message-ID: | 200210190207.g9J27tO10949@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Patch applied. Thanks.
---------------------------------------------------------------------------
Neil Conway wrote:
> This patch adds some missing functions for float8 math operations,
> specifically ceil(), floor(), and sign(). There may be other functions
> that need to be added, but this is a start. I've included some simple
> regression tests.
>
> Unless anyone sees a problem, please add this to the 7.4 queue.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073