Re: Fixing inconsistencies in the list of books

When I added a book to the list a while back I realized that the list is quite
inconsistent in how it lists and even spells authors (and in more minor
nitpicks, punctuation). The case at hand is "Hans-Juergen Schoenig" and
"Hans-Jürgen Schönig". The attached patch attempts to make it consistent in
how authors are spelled using HTML entities, and how we list multiple authors.

Longer term it might make sense to move this information to the database and
template the list, but that feels like a low-priority task (if one at all)
given the low churn of this list.

--
Daniel Gustafsson https://vmware.com/

Hi

On Thu, 10 Nov 2022 at 12:11, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:

> When I added a book to the list a while back I realized that the list is
> quite
> inconsistent in how it lists and even spells authors (and in more minor
> nitpicks, punctuation). The case at hand is "Hans-Juergen Schoenig" and
> "Hans-Jürgen Schönig". The attached patch attempts to make it consistent
> in
> how authors are spelled using HTML entities, and how we list multiple
> authors.
>
> Longer term it might make sense to move this information to the database
> and
> template the list, but that feels like a low-priority task (if one at all)
> given the low churn of this list.
>

Looks good to me. The only correction I would offer is that "et al" should
only be preceded by a comma if there is more than one name listed. Eg.

Dave Page et al.
Dave Page, Daniel Gustafsson, et al.

--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

> On 10 Nov 2022, at 13:40, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> The only correction I would offer is that "et al" should only be preceded by a comma if there is more than one name listed.

Thanks, I'll fix that before committing.

--
Daniel Gustafsson https://vmware.com/

> On Nov 10, 2022, at 7:11 AM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> When I added a book to the list a while back I realized that the list is quite
> inconsistent in how it lists and even spells authors (and in more minor
> nitpicks, punctuation). The case at hand is "Hans-Juergen Schoenig" and
> "Hans-Jürgen Schönig". The attached patch attempts to make it consistent in
> how authors are spelled using HTML entities, and how we list multiple authors.

Many of these were user supplied and some a very long
time ago, so there’s no surprise there are inconsistencies.

> Longer term it might make sense to move this information to the database and
> template the list, but that feels like a low-priority task (if one at all)
> given the low churn of this list.

We’ve discussed this in the past and decided not to do it. Given
how we handle images, we would still need to have a commit
with a new book, so I don’t think we save much, and
some of
the consistency errors are not prevented by putting it into
a database.

Jonathan

> On Nov 10, 2022, at 8:13 AM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> 
>>
>>> On 10 Nov 2022, at 13:40, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> The only correction I would offer is that "et al" should only be preceded by a comma if there is more than one name listed.
>
> Thanks, I'll fix that before committing.

Please wait until after the update release.

Thanks,

Jonathan

> On 10 Nov 2022, at 14:29, Jonathan S. Katz <jkatz(at)postgresql(dot)org> wrote:
>
>> On Nov 10, 2022, at 8:13 AM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>>> On 10 Nov 2022, at 13:40, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>> The only correction I would offer is that "et al" should only be preceded by a comma if there is more than one name listed.
>>
>> Thanks, I'll fix that before committing.
>
> Please wait until after the update release.

With the releases done, I've applied this. Thanks for review!

--
Daniel Gustafsson https://vmware.com/