Re: Apparently deprecated code in planner.c

Lists: pgsql-hackers
From: "Dickson S(dot) Guedes" <listas(at)guedesoft(dot)net>
To: pg-dev <pgsql-hackers(at)postgresql(dot)org>
Subject: Apparently deprecated code in planner.c
Date: 2016-01-10 22:28:16
Message-ID: CAHHcrerCpweNqfkwTm7+_SPh9OU7d97s97=fSaZyRK=1xn8PyA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi all,

I'm wondering whether the #ifdef FORCE_PARALLEL_MODE code [1] was deprecated:

*
* FIXME: It's assumed that code further down will set parallelModeNeeded
* to true if a parallel path is actually chosen. Since the core
* parallelism code isn't committed yet, this currently never happens.
*/
#ifdef FORCE_PARALLEL_MODE
glob->parallelModeNeeded = glob->parallelModeOK;
#else
glob->parallelModeNeeded = false;
#endif

[1] http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/optimizer/plan/planner.c;h=147c4deef3bb708ebb32b6781330f6ed980fc90c;hb=HEAD#l245

[]s
--
Dickson S. Guedes
mail/xmpp: guedes(at)guedesoft(dot)net - skype: guediz
http://github.com/guedes - http://guedesoft.net
http://www.postgresql.org.br

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: "Dickson S(dot) Guedes" <listas(at)guedesoft(dot)net>
Cc: pg-dev <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Apparently deprecated code in planner.c
Date: 2016-01-11 02:32:02
Message-ID: CA+Tgmob=VxBEcN8YY1YrswKLboAU8dpa7bBOrNSDCqHmzYkBGQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sun, Jan 10, 2016 at 5:28 PM, Dickson S. Guedes <listas(at)guedesoft(dot)net> wrote:
> Hi all,
>
> I'm wondering whether the #ifdef FORCE_PARALLEL_MODE code [1] was deprecated:
>
> *
> * FIXME: It's assumed that code further down will set parallelModeNeeded
> * to true if a parallel path is actually chosen. Since the core
> * parallelism code isn't committed yet, this currently never happens.
> */
> #ifdef FORCE_PARALLEL_MODE
> glob->parallelModeNeeded = glob->parallelModeOK;
> #else
> glob->parallelModeNeeded = false;
> #endif

That comment is obsolete, but defining FORCE_PARALLEL_MODE is still a
useful thing to do for testing purposes.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company