Re: Five Swedish po-files for version 9.4.

Hello there,

I hope to see five translation files updated with Swedish
message texts. Three of the are brushing up on almost
complete files, while two of them, "initdb-sv.po" and
"pgscripts-sv.po", would be new in publishable state.
They are all consistent as to translation principles,
and are for version 9.4!

Best regards,
Mats Erik Andersson

On Tue, Nov 25, 2014 at 10:48 PM, Mats Erik Andersson
<bsd(at)gisladisker(dot)se> wrote:
> Hello there,
>
> I hope to see five translation files updated with Swedish
> message texts. Three of the are brushing up on almost
> complete files, while two of them, "initdb-sv.po" and
> "pgscripts-sv.po", would be new in publishable state.
> They are all consistent as to translation principles,
> and are for version 9.4!

Hello, thank you very much.

I've committed your files, I can push them to the master branch as
soon as I've solved a few problems (not really in your files, more in
other ones in the sv translation).

The only problem I've found in the files you provided is summarized by
this change I've made on top of one of them:

diff --git a/sv/pg_ctl.po b/sv/pg_ctl.po
index 4688969..516e6f3 100644
--- a/sv/pg_ctl.po
+++ b/sv/pg_ctl.po
@@ -503,8 +503,7 @@ msgstr "Användning:\n"
#: pg_ctl.c:1863
#, c-format
msgid " %s init[db] [-D DATADIR] [-s] [-o \"OPTIONS\"]\n"
-msgstr " %s init[db] [-D DATAKAT] [-s] [-o \"FLAGGOR\"]\n"
-#msgstr " %s init[db] [-D DATAKAT] [-s] [-o \"FLAGGOR\"]\n"
+msgstr " %s init[db] [-D DATAKAT] [-s] [-o \"FLAGGOR\"]\n"

#: pg_ctl.c:1864
#, c-format

the #msgstr comment is an error: a .po user comment should have a
whitespace after the hash char, otherwise it is interpreted as a flag.
ISTM though that the commented-out version is more correct as it
preserves the original alignment. Is this right or do you have reasons
to prefer the previous version, with less whitespace after "init[db]"?

Thank you again,

-- Daniele

onsdag den 26 november 2014 klockan 00:17 skrev Daniele Varrazzo detta:
> The only problem I've found in the files you provided is summarized by
> this change I've made on top of one of them:
>
> diff --git a/sv/pg_ctl.po b/sv/pg_ctl.po
> index 4688969..516e6f3 100644
> --- a/sv/pg_ctl.po
> +++ b/sv/pg_ctl.po
> @@ -503,8 +503,7 @@ msgstr "Användning:\n"
> #: pg_ctl.c:1863
> #, c-format
> msgid " %s init[db] [-D DATADIR] [-s] [-o \"OPTIONS\"]\n"
> -msgstr " %s init[db] [-D DATAKAT] [-s] [-o \"FLAGGOR\"]\n"
> -#msgstr " %s init[db] [-D DATAKAT] [-s] [-o \"FLAGGOR\"]\n"
> +msgstr " %s init[db] [-D DATAKAT] [-s] [-o \"FLAGGOR\"]\n"
>
> #: pg_ctl.c:1864
> #, c-format
>
> the #msgstr comment is an error: a .po user comment should have a
> whitespace after the hash char, otherwise it is interpreted as a flag.
> ISTM though that the commented-out version is more correct as it
> preserves the original alignment. Is this right or do you have reasons
> to prefer the previous version, with less whitespace after "init[db]"?

Good catch. The line with an initial hash mark was inadveredly left put,
it should have been removed. Yes, I did decrease the amount of white space,
thus ignoring the original text. I simply think that a shorter distance
gives a more pleasant visual impression. Pulling it as far as the first
"[-w]" in the next line is too drastic, so I aligned "[-D" on the next
possible position. It breaks with the later position of "[-D" for other
modi, but I opted for a better visual impression.

I hope to suggest some more translation files in a close future.

Best regards,
Mats Erik Andersson

On Wed, Nov 26, 2014 at 3:33 PM, Mats Erik Andersson <bsd(at)gisladisker(dot)se> wrote:
> onsdag den 26 november 2014 klockan 00:17 skrev Daniele Varrazzo detta:

>> the #msgstr comment is an error: a .po user comment should have a
>> whitespace after the hash char, otherwise it is interpreted as a flag.
>> ISTM though that the commented-out version is more correct as it
>> preserves the original alignment. Is this right or do you have reasons
>> to prefer the previous version, with less whitespace after "init[db]"?
>
> Good catch. The line with an initial hash mark was inadveredly left put,
> it should have been removed. Yes, I did decrease the amount of white space,
> thus ignoring the original text. I simply think that a shorter distance
> gives a more pleasant visual impression. Pulling it as far as the first
> "[-w]" in the next line is too drastic, so I aligned "[-D" on the next
> possible position. It breaks with the later position of "[-D" for other
> modi, but I opted for a better visual impression.

Ok, in this case I will only remove the line with the malformed #msgtr
comment and leave your version of the translation. I will commit your
files when I'm back home, in a few hours.

-- Daniele

On Wed, Nov 26, 2014 at 3:40 PM, Daniele Varrazzo
<daniele(dot)varrazzo(at)gmail(dot)com> wrote:
>
> Ok, in this case I will only remove the line with the malformed #msgtr
> comment and leave your version of the translation. I will commit your
> files when I'm back home, in a few hours.

Committed and pushed, thank you.

-- Daniele

Mats Erik Andersson wrote:

> Good catch. The line with an initial hash mark was inadveredly left put,
> it should have been removed. Yes, I did decrease the amount of white space,
> thus ignoring the original text. I simply think that a shorter distance
> gives a more pleasant visual impression. Pulling it as far as the first
> "[-w]" in the next line is too drastic, so I aligned "[-D" on the next
> possible position. It breaks with the later position of "[-D" for other
> modi, but I opted for a better visual impression.

This seems acceptable and I also do it for spanish translation in a few
places. Really, the only thing that matters here is that the complete
--help output is aligned nicely.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services