| Lists: | pgsql-www |
|---|
| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | PostgreSQL WWW <pgsql-www(at)postgresql(dot)org> |
| Subject: | Small bugfixes for the commitfest app |
| Date: | 2017-06-19 20:57:34 |
| Message-ID: | B7610439-D90E-4B74-9771-371A0C992E06@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-www |
Spotted two small bugs while reading the code for the commitfest2 app.
* The committer modal dialogue isn’t closing its <form>
* The thead/tbody on the main patch listing page doesnt contain the same
number of columns due to thead omitting hidden columns. The fix is to
include an empty <td></td> pair.
Fixed in the attached patches.
cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| cf_form.patch | application/octet-stream | 753 bytes |
| cf_table_columns.patch | application/octet-stream | 1.1 KB |
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL WWW <pgsql-www(at)postgresql(dot)org> |
| Subject: | Re: Small bugfixes for the commitfest app |
| Date: | 2017-06-20 06:53:42 |
| Message-ID: | CABUevExSGhSm3J=XYYT_EYakEOiOmUXL8wLxRqd5BQtS90u5pQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-www |
On Mon, Jun 19, 2017 at 10:57 PM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> Spotted two small bugs while reading the code for the commitfest2 app.
>
> * The committer modal dialogue isn’t closing its <form>
> * The thead/tbody on the main patch listing page doesnt contain the same
> number of columns due to thead omitting hidden columns. The fix is to
> include an empty <td></td> pair.
>
> Fixed in the attached patches.
>
Both applied, thanks!
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>