Wrong Typo

Lists: pgsql-docs
From: Mehmet Emin KARAKAŞ <emin100(at)gmail(dot)com>
To: pgsql-docs(at)postgresql(dot)org
Subject: Wrong Typo
Date: 2015-07-29 09:21:43
Message-ID: CANQrdXC5Se7891d=XCWfgHKGNsVD742reOKiDxStuH3i3thPvA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-docs

Hi Everybody,

I saw wrong typo in `ALTER FOREIGN TABLE´ documentation page.(
http://www.postgresql.org/docs/9.1/static/sql-alterforeigntable.html) On
the bottom of page have an example like that.
ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET
opt2, 'value2', DROP opt3 'value3');

Don't need to put comma set options values. This is wrong usage and not
working. Need to remove comma after opt2. All of documentation series the
same(9.1,9.2,9.3,9.4...).True usage is;

ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET
opt2 'value2', DROP opt3 'value3');

Thanks.

--
MEHMET EMİN KARAKAŞ

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Mehmet Emin KARAKAŞ <emin100(at)gmail(dot)com>
Cc: pgsql-docs(at)postgresql(dot)org
Subject: Re: Wrong Typo
Date: 2015-09-02 01:15:16
Message-ID: 20150902011516.GH27332@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-docs

On Wed, Jul 29, 2015 at 12:21:43PM +0300, Mehmet Emin KARAKAŞ wrote:
> Hi Everybody,
>
> I saw wrong typo in `ALTER FOREIGN TABLE´ documentation page.(http://
> www.postgresql.org/docs/9.1/static/sql-alterforeigntable.html) On the bottom
> of page have an example like that.
> ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET opt2,
> 'value2', DROP opt3 'value3');
>
> Don't need to put comma  set options values. This is wrong usage and not
> working. Need to remove comma after opt2. All of documentation series the same
> (9.1,9.2,9.3,9.4...).True usage is;
>  
> ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET opt2
> 'value2', DROP opt3 'value3');

This has been fixed, thanks.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +