Re: Fix FTBFS for prometheus-sql-exporter

Lists: pgsql-pkg-debian
From: Bradford Boyle <bradford(dot)d(dot)boyle(at)gmail(dot)com>
To: pgsql-pkg-debian(at)lists(dot)postgresql(dot)org
Subject: Fix FTBFS for prometheus-sql-exporter
Date: 2024-04-04 06:52:16
Message-ID: CAOMoQbRyvDMydCY6wDgcD3dgrgdEk3vZuA2+G06yewyGcFRFSw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-pkg-debian

Hello All,

I've pushed some changes to prometheus-sql-exporter to address bug
#1067292 [1]. The Salsa CI pipelines are green. I'd like to request a
review and upload as cycles permit.

Let me know if anything needs changes.

Thanks,
--Bradford

[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067292

From: Christoph Berg <myon(at)debian(dot)org>
To: Bradford Boyle <bradford(dot)d(dot)boyle(at)gmail(dot)com>
Cc: pgsql-pkg-debian(at)lists(dot)postgresql(dot)org
Subject: Re: Fix FTBFS for prometheus-sql-exporter
Date: 2024-04-04 08:52:06
Message-ID: Zg5qNs93lYnph4-n@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-pkg-debian

Re: Bradford Boyle
> I've pushed some changes to prometheus-sql-exporter to address bug
> #1067292 [1]. The Salsa CI pipelines are green. I'd like to request a
> review and upload as cycles permit.

Hi Bradford,

thanks for the update, uploaded!

I had to revert the patch on the older distributions since go was
unhappy:

https://pgdgbuild.dus.dg-i.net/job/prometheus-sql-exporter-binaries/31/

I'm a bit worried that Ubuntu noble also needed the revert; we might
need to un-revert it there if they change the toolchain before the
release.

https://git.postgresql.org/gitweb/?p=pgapt.git;a=blobdiff;f=jenkins/generate-pgdg-source;h=1164b53400014b3275c7ac43bd7c39d1754a712e;hp=38db1e32a06e43a657aeab8c01f5f736efa1ae07;hb=753dc50b6b055494e0ef84d13a0dd8cdc0619680;hpb=2e6e6ce09c1d2c329b085618ef9be8665339b505

Christoph

From: Bradford Boyle <bradford(dot)d(dot)boyle(at)gmail(dot)com>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: pgsql-pkg-debian(at)lists(dot)postgresql(dot)org
Subject: Re: Fix FTBFS for prometheus-sql-exporter
Date: 2024-04-05 03:07:31
Message-ID: CAOMoQbSwhpd1RWGE3zBFcU36FtvsHWnrVnsg0Bb70pRfoKpj-w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-pkg-debian

Hi Christoph,

> I had to revert the patch on the older distributions since go was
> unhappy:

I forgot to mention it in my original email, but I thought the patch
might be an issue on older distributions. In the future, is there a way
I can trigger a snapshot build on pgdgbuild before notifying the mailing
list?

> I'm a bit worried that Ubuntu noble also needed the revert; we might
> need to un-revert it there if they change the toolchain before the
> release.

It looks like the replacement API is only available in
github.com/prometheus/client_golang(at)v1(dot)19(dot)0 and Ubuntu noble (as of
20240404) still is on 1.18.0. Unless 1.19.0 gets uploaded to noble, the
patch shouldn't need to be un-reverted. I will keep an eye on this.

--Bradford