Re: VC++ psql build broken

> -----Original Message-----
> From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> Sent: 10 September 2004 17:41
> To: pgman(at)candle(dot)pha(dot)pa(dot)us
> Cc: Dave Page; PgSQL Win32 developers
> Subject: Re: [pgsql-hackers-win32] VC++ psql build broken
>
>
> Now that I think of it, flex will not work because there is
> no *.mak rule to run it. You would have to run it manually,
> or write a *.mak rule for it. If someone does, please do
> bcc.make too.

Patch attached. It works find under VC++, but the Borland mod is an
untested copy/paste.

Unfortunately, psql still doesn't build giving the errors below. I
should point out that I have no interest in psql but am happy to keep
testing the build. I do wonder if there is any need to maintain these
makefiles at all now it builds under Mingw - it's not like psql is a
library like libpq that vc++ or bcc needs to link to (which I do need).

Regards, Dave.

cd ..\..\bin\psql
nmake /f win32.mak

Microsoft (R) Program Maintenance Utility Version 6.00.8168.0
Copyright (C) Microsoft Corp 1988-1998. All rights reserved.

flex.exe -Cfe -opsqlscan.c psqlscan.l
echo #define PGBINDIR "" >"..\..\port\pg_config_paths.h"
echo #define PGSHAREDIR "" >>"..\..\port\pg_config_paths.h"
echo #define SYSCONFDIR "" >>"..\..\port\pg_config_paths.h"
echo #define INCLUDEDIR "" >>"..\..\port\pg_config_paths.h"
echo #define PKGINCLUDEDIR "" >>"..\..\port\pg_config_paths.h"
echo #define INCLUDEDIRSERVER ""
>>"..\..\port\pg_config_paths.h"
echo #define LIBDIR "" >>"..\..\port\pg_config_paths.h"
echo #define PKGLIBDIR "" >>"..\..\port\pg_config_paths.h"
echo #define LOCALEDIR "" >>"..\..\port\pg_config_paths.h"
cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nma03280.
sprompt.c
cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nmb03280.
getopt.c
cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nmc03280.
getopt_long.c
cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nmd03280.
path.c
cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nme03280.
command.c
C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
redefini
tion; different linkage
..\..\include\port.h(167) : see declaration of 'pgrename'
C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
redefini
tion; different linkage
..\..\include\port.h(168) : see declaration of 'pgunlink'
common.c
C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
redefini
tion; different linkage
..\..\include\port.h(167) : see declaration of 'pgrename'
C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
redefini
tion; different linkage
..\..\include\port.h(168) : see declaration of 'pgunlink'
common.c(536) : warning C4018: '<' : signed/unsigned mismatch
help.c
input.c
stringutils.c
mainloop.c
mainloop.c(253) : warning C4018: '==' : signed/unsigned mismatch
copy.c
C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
redefini
tion; different linkage
..\..\include\port.h(167) : see declaration of 'pgrename'
C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
redefini
tion; different linkage
..\..\include\port.h(168) : see declaration of 'pgunlink'
startup.c
C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
redefini
tion; different linkage
..\..\include\port.h(167) : see declaration of 'pgrename'
C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
redefini
tion; different linkage
..\..\include\port.h(168) : see declaration of 'pgunlink'
prompt.c
C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
redefini
tion; different linkage
..\..\include\port.h(167) : see declaration of 'pgrename'
C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
redefini
tion; different linkage
..\..\include\port.h(168) : see declaration of 'pgunlink'
variables.c
large_obj.c
print.c
print.c(1238) : warning C4090: 'function' : different 'const' qualifiers
print.c(1238) : warning C4022: 'free' : pointer mismatch for actual
parameter 1
print.c(1239) : warning C4090: 'function' : different 'const' qualifiers
print.c(1239) : warning C4022: 'free' : pointer mismatch for actual
parameter 1
describe.c
psqlscan.c
tab-complete.c
mbprint.c
NMAKE : fatal error U1077: 'cl.exe' : return code '0x2'
Stop.
NMAKE : fatal error U1077: 'C:\PROGRA~1\MICROS~3\VC98\BIN\NMAKE.EXE' :
return co
de '0x2'
Stop.

How does your Win32 system rename prototype differ from what is in
port.h?

extern int pgrename(const char *from, const char *to);
extern int pgunlink(const char *path);

Good question on wether we need to keep this working but it would be
nice to keep it I guess for client-only installs that want to build from
source using non-Mingw.

---------------------------------------------------------------------------

Dave Page wrote:
>
>
> > -----Original Message-----
> > From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> > Sent: 10 September 2004 17:41
> > To: pgman(at)candle(dot)pha(dot)pa(dot)us
> > Cc: Dave Page; PgSQL Win32 developers
> > Subject: Re: [pgsql-hackers-win32] VC++ psql build broken
> >
> >
> > Now that I think of it, flex will not work because there is
> > no *.mak rule to run it. You would have to run it manually,
> > or write a *.mak rule for it. If someone does, please do
> > bcc.make too.
>
> Patch attached. It works find under VC++, but the Borland mod is an
> untested copy/paste.
>
> Unfortunately, psql still doesn't build giving the errors below. I
> should point out that I have no interest in psql but am happy to keep
> testing the build. I do wonder if there is any need to maintain these
> makefiles at all now it builds under Mingw - it's not like psql is a
> library like libpq that vc++ or bcc needs to link to (which I do need).
>
> Regards, Dave.
>
> cd ..\..\bin\psql
> nmake /f win32.mak
>
> Microsoft (R) Program Maintenance Utility Version 6.00.8168.0
> Copyright (C) Microsoft Corp 1988-1998. All rights reserved.
>
> flex.exe -Cfe -opsqlscan.c psqlscan.l
> echo #define PGBINDIR "" >"..\..\port\pg_config_paths.h"
> echo #define PGSHAREDIR "" >>"..\..\port\pg_config_paths.h"
> echo #define SYSCONFDIR "" >>"..\..\port\pg_config_paths.h"
> echo #define INCLUDEDIR "" >>"..\..\port\pg_config_paths.h"
> echo #define PKGINCLUDEDIR "" >>"..\..\port\pg_config_paths.h"
> echo #define INCLUDEDIRSERVER ""
> >>"..\..\port\pg_config_paths.h"
> echo #define LIBDIR "" >>"..\..\port\pg_config_paths.h"
> echo #define PKGLIBDIR "" >>"..\..\port\pg_config_paths.h"
> echo #define LOCALEDIR "" >>"..\..\port\pg_config_paths.h"
> cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nma03280.
> sprompt.c
> cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nmb03280.
> getopt.c
> cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nmc03280.
> getopt_long.c
> cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nmd03280.
> path.c
> cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nme03280.
> command.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
> redefini
> tion; different linkage
> ..\..\include\port.h(167) : see declaration of 'pgrename'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
> redefini
> tion; different linkage
> ..\..\include\port.h(168) : see declaration of 'pgunlink'
> common.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
> redefini
> tion; different linkage
> ..\..\include\port.h(167) : see declaration of 'pgrename'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
> redefini
> tion; different linkage
> ..\..\include\port.h(168) : see declaration of 'pgunlink'
> common.c(536) : warning C4018: '<' : signed/unsigned mismatch
> help.c
> input.c
> stringutils.c
> mainloop.c
> mainloop.c(253) : warning C4018: '==' : signed/unsigned mismatch
> copy.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
> redefini
> tion; different linkage
> ..\..\include\port.h(167) : see declaration of 'pgrename'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
> redefini
> tion; different linkage
> ..\..\include\port.h(168) : see declaration of 'pgunlink'
> startup.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
> redefini
> tion; different linkage
> ..\..\include\port.h(167) : see declaration of 'pgrename'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
> redefini
> tion; different linkage
> ..\..\include\port.h(168) : see declaration of 'pgunlink'
> prompt.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
> redefini
> tion; different linkage
> ..\..\include\port.h(167) : see declaration of 'pgrename'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
> redefini
> tion; different linkage
> ..\..\include\port.h(168) : see declaration of 'pgunlink'
> variables.c
> large_obj.c
> print.c
> print.c(1238) : warning C4090: 'function' : different 'const' qualifiers
> print.c(1238) : warning C4022: 'free' : pointer mismatch for actual
> parameter 1
> print.c(1239) : warning C4090: 'function' : different 'const' qualifiers
> print.c(1239) : warning C4022: 'free' : pointer mismatch for actual
> parameter 1
> describe.c
> psqlscan.c
> tab-complete.c
> mbprint.c
> NMAKE : fatal error U1077: 'cl.exe' : return code '0x2'
> Stop.
> NMAKE : fatal error U1077: 'C:\PROGRA~1\MICROS~3\VC98\BIN\NMAKE.EXE' :
> return co
> de '0x2'
> Stop.

Content-Description: psql_win32_makefiles.diff

[ Attachment, skipping... ]

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Bruce Momjian wrote:
> How does your Win32 system rename prototype differ from what is in
> port.h?

What is the need of *any* special file handling functions for client tools?

Regards,
Andreas

Andreas Pflug wrote:
> Bruce Momjian wrote:
> > How does your Win32 system rename prototype differ from what is in
> > port.h?
>
> What is the need of *any* special file handling functions for client tools?

We could avoid it but it does give us Unix semantics so it seemed good
to keep it if we could.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Bruce Momjian wrote:
> Andreas Pflug wrote:
>
>>Bruce Momjian wrote:
>>
>>>How does your Win32 system rename prototype differ from what is in
>>>port.h?
>>
>>What is the need of *any* special file handling functions for client tools?
>
>
> We could avoid it but it does give us Unix semantics so it seemed good
> to keep it if we could.
>

As you can see it creates much pain, without any use. The functions are
for backend concurrent/shared access purposes only.

Regards,
Andreas

Andreas Pflug wrote:
> Bruce Momjian wrote:
> > Andreas Pflug wrote:
> >
> >>Bruce Momjian wrote:
> >>
> >>>How does your Win32 system rename prototype differ from what is in
> >>>port.h?
> >>
> >>What is the need of *any* special file handling functions for client tools?
> >
> >
> > We could avoid it but it does give us Unix semantics so it seemed good
> > to keep it if we could.
> >
>
> As you can see it creates much pain, without any use. The functions are
> for backend concurrent/shared access purposes only.

Are we sure of that always? And we don't know what other applications
might be looking at those files.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

I have applied the attached patch. I changed psqlscan to only require
flex when it needs to rebuild the flex output:

psqlscan.c: psqlscan.l
$(FLEX) -Cfe -opsqlscan.c psqlscan.l

Because we normally ship the flex output in the tarball I didn't bother
to document that flex is required for CVS builds. We already require
flex for CVS builds so this isn't anything special.

---------------------------------------------------------------------------

Dave Page wrote:
>
>
> > -----Original Message-----
> > From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> > Sent: 10 September 2004 17:41
> > To: pgman(at)candle(dot)pha(dot)pa(dot)us
> > Cc: Dave Page; PgSQL Win32 developers
> > Subject: Re: [pgsql-hackers-win32] VC++ psql build broken
> >
> >
> > Now that I think of it, flex will not work because there is
> > no *.mak rule to run it. You would have to run it manually,
> > or write a *.mak rule for it. If someone does, please do
> > bcc.make too.
>
> Patch attached. It works find under VC++, but the Borland mod is an
> untested copy/paste.
>
> Unfortunately, psql still doesn't build giving the errors below. I
> should point out that I have no interest in psql but am happy to keep
> testing the build. I do wonder if there is any need to maintain these
> makefiles at all now it builds under Mingw - it's not like psql is a
> library like libpq that vc++ or bcc needs to link to (which I do need).
>
> Regards, Dave.
>
> cd ..\..\bin\psql
> nmake /f win32.mak
>
> Microsoft (R) Program Maintenance Utility Version 6.00.8168.0
> Copyright (C) Microsoft Corp 1988-1998. All rights reserved.
>
> flex.exe -Cfe -opsqlscan.c psqlscan.l
> echo #define PGBINDIR "" >"..\..\port\pg_config_paths.h"
> echo #define PGSHAREDIR "" >>"..\..\port\pg_config_paths.h"
> echo #define SYSCONFDIR "" >>"..\..\port\pg_config_paths.h"
> echo #define INCLUDEDIR "" >>"..\..\port\pg_config_paths.h"
> echo #define PKGINCLUDEDIR "" >>"..\..\port\pg_config_paths.h"
> echo #define INCLUDEDIRSERVER ""
> >>"..\..\port\pg_config_paths.h"
> echo #define LIBDIR "" >>"..\..\port\pg_config_paths.h"
> echo #define PKGLIBDIR "" >>"..\..\port\pg_config_paths.h"
> echo #define LOCALEDIR "" >>"..\..\port\pg_config_paths.h"
> cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nma03280.
> sprompt.c
> cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nmb03280.
> getopt.c
> cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nmc03280.
> getopt_long.c
> cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nmd03280.
> path.c
> cl.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nme03280.
> command.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
> redefini
> tion; different linkage
> ..\..\include\port.h(167) : see declaration of 'pgrename'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
> redefini
> tion; different linkage
> ..\..\include\port.h(168) : see declaration of 'pgunlink'
> common.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
> redefini
> tion; different linkage
> ..\..\include\port.h(167) : see declaration of 'pgrename'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
> redefini
> tion; different linkage
> ..\..\include\port.h(168) : see declaration of 'pgunlink'
> common.c(536) : warning C4018: '<' : signed/unsigned mismatch
> help.c
> input.c
> stringutils.c
> mainloop.c
> mainloop.c(253) : warning C4018: '==' : signed/unsigned mismatch
> copy.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
> redefini
> tion; different linkage
> ..\..\include\port.h(167) : see declaration of 'pgrename'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
> redefini
> tion; different linkage
> ..\..\include\port.h(168) : see declaration of 'pgunlink'
> startup.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
> redefini
> tion; different linkage
> ..\..\include\port.h(167) : see declaration of 'pgrename'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
> redefini
> tion; different linkage
> ..\..\include\port.h(168) : see declaration of 'pgunlink'
> prompt.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(176) : error C2375: 'pgrename' :
> redefini
> tion; different linkage
> ..\..\include\port.h(167) : see declaration of 'pgrename'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\io.h(244) : error C2375: 'pgunlink' :
> redefini
> tion; different linkage
> ..\..\include\port.h(168) : see declaration of 'pgunlink'
> variables.c
> large_obj.c
> print.c
> print.c(1238) : warning C4090: 'function' : different 'const' qualifiers
> print.c(1238) : warning C4022: 'free' : pointer mismatch for actual
> parameter 1
> print.c(1239) : warning C4090: 'function' : different 'const' qualifiers
> print.c(1239) : warning C4022: 'free' : pointer mismatch for actual
> parameter 1
> describe.c
> psqlscan.c
> tab-complete.c
> mbprint.c
> NMAKE : fatal error U1077: 'cl.exe' : return code '0x2'
> Stop.
> NMAKE : fatal error U1077: 'C:\PROGRA~1\MICROS~3\VC98\BIN\NMAKE.EXE' :
> return co
> de '0x2'
> Stop.

Content-Description: psql_win32_makefiles.diff

[ Attachment, skipping... ]

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073