| Lists: | pgsql-hackers-win32 |
|---|
| From: | Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com> |
|---|---|
| To: | 'Merlin Moncure' <merlin(dot)moncure(at)rcsonline(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Win 32 hackers PGSQL <pgsql-hackers-win32(at)postgresql(dot)org> |
| Subject: | Re: [PERFORM] scalability issues on win32 |
| Date: | 2004-12-03 01:59:20 |
| Message-ID: | E80765D3BE190745B72F81EFB8332AAB014CFA@harold.memetrics.local |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers-win32 |
Hi Merlin,
> On a probably unrelated note:
> Can some other win32 hacker try the following?
> Download the latest cvs sources from the server and edit configure,
> replacing all instances of '8.0beta5' with '8.0' etc. as is
> will be when released. Following that do a full make/make clean. After
> that try and start he server with pg_ctl.exe and tell me if it succeeds or
not.
I can confirm this failure.
(in my case at least) pg_ctl is not seeing the full version string of the
postmaster in find_other_exec. This is due to the single call to ReadFile in
pipe_read_line, which is not returning the entire version string (losing all
characters beyond the last decimal point in the version string). A
subsequent call to ReadFile picks up the remainder of the string. I don't
see that we can rely on a single call returning the entire version string.
If someone can run with this, I've attached initial looping changes for
pipe_read_line. However I'm not sure of the correct terminating condition
(gets into a call to ReadFile that never returns; the WaitForSingleObject
appears insufficient as a precondition for ReadFile) and just don't have
time to complete it right now.
Cheers,
Claudio
| Attachment | Content-Type | Size |
|---|---|---|
| pipe_read.diff | application/octet-stream | 1.8 KB |
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com> |
| Cc: | "'Merlin Moncure'" <merlin(dot)moncure(at)rcsonline(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Win 32 hackers PGSQL <pgsql-hackers-win32(at)postgresql(dot)org> |
| Subject: | Re: [PERFORM] scalability issues on win32 |
| Date: | 2004-12-03 02:11:30 |
| Message-ID: | 41AFCB52.60906@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers-win32 |
Claudio Natoli wrote:
>Hi Merlin,
>
>
>
>>On a probably unrelated note:
>>Can some other win32 hacker try the following?
>>Download the latest cvs sources from the server and edit configure,
>>replacing all instances of '8.0beta5' with '8.0' etc. as is
>>will be when released. Following that do a full make/make clean. After
>>that try and start he server with pg_ctl.exe and tell me if it succeeds or
>>
>>
>not.
>
>I can confirm this failure.
>
>(in my case at least) pg_ctl is not seeing the full version string of the
>postmaster in find_other_exec. This is due to the single call to ReadFile in
>pipe_read_line, which is not returning the entire version string (losing all
>characters beyond the last decimal point in the version string). A
>subsequent call to ReadFile picks up the remainder of the string. I don't
>see that we can rely on a single call returning the entire version string.
>
>
How is it that this has not bitten us elsewhere? Are we only reading
tiny things from pipes in other cases so that a single read works? It
seems very strange that a shorter version string should cause the failure.
cheers
andrew
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com> |
| Cc: | "'Merlin Moncure'" <merlin(dot)moncure(at)rcsonline(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Win 32 hackers PGSQL <pgsql-hackers-win32(at)postgresql(dot)org> |
| Subject: | Re: [PERFORM] scalability issues on win32 |
| Date: | 2004-12-17 00:25:14 |
| Message-ID: | 200412170025.iBH0PEa04860@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers-win32 |
Claudio, I need this completed so we can get it into CVS. Without it a
8.0.0 version string will fail to compare.
---------------------------------------------------------------------------
Claudio Natoli wrote:
>
> Hi Merlin,
>
> > On a probably unrelated note:
> > Can some other win32 hacker try the following?
> > Download the latest cvs sources from the server and edit configure,
> > replacing all instances of '8.0beta5' with '8.0' etc. as is
> > will be when released. Following that do a full make/make clean. After
> > that try and start he server with pg_ctl.exe and tell me if it succeeds or
> not.
>
> I can confirm this failure.
>
> (in my case at least) pg_ctl is not seeing the full version string of the
> postmaster in find_other_exec. This is due to the single call to ReadFile in
> pipe_read_line, which is not returning the entire version string (losing all
> characters beyond the last decimal point in the version string). A
> subsequent call to ReadFile picks up the remainder of the string. I don't
> see that we can rely on a single call returning the entire version string.
>
> If someone can run with this, I've attached initial looping changes for
> pipe_read_line. However I'm not sure of the correct terminating condition
> (gets into a call to ReadFile that never returns; the WaitForSingleObject
> appears insufficient as a precondition for ReadFile) and just don't have
> time to complete it right now.
>
> Cheers,
> Claudio
>
>
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: the planner will ignore your desire to choose an index scan if your
> joining column's datatypes do not match
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073