Re: Re: [HACKERS] ODBC Driver int8 Patch

Patch applied. Thanks.

[ Charset ISO-8859-1 unsupported, converting... ]
> Hi Bruce,
>
> Did you accept this patch in the end or was it rejected?
>
> Regards, Dave.
>
> > -----Original Message-----
> > From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> > Sent: 16 January 2001 16:50
> > To: Dave Page
> > Cc: 'pgsql-hackers(at)postgresql(dot)org'
> > Subject: Re: [HACKERS] ODBC Driver int8 Patch
> >
> >
> > As I remember, the problem is that this makes us match the
> > ODBC v2 spec,
> > but then we would not match the v3 spec. Is that correct?
> >
> >
> > [ Charset ISO-8859-1 unsupported, converting... ]
> > > Hi,
> > >
> > > It was suggested that I post this patch here as no notice
> > was taken of it
> > > when posted to interfaces!
> > >
> > > This fixes problems with int8 columns which are reported by
> > the driver as
> > > SQL_BIGINT rather than SQL_CHAR as per the ODBC v2 spec.
> > Specifically, I
> > > have had problems with MS ADO - any queries that contain an
> > int8 column in
> > > the resultset will *always* return an empty recordset.
> > >
> > > Regards,
> > >
> > > Dave.
> > >
> > > *** pgtypes.c.orig Fri Dec 22 09:12:22 2000
> > > --- pgtypes.c Fri Dec 22 09:12:22 2000
> > > ***************
> > > *** 217,223 ****
> > > case PG_TYPE_XID:
> > > case PG_TYPE_INT4: return SQL_INTEGER;
> > >
> > > ! case PG_TYPE_INT8: return SQL_BIGINT;
> > > case PG_TYPE_NUMERIC: return SQL_NUMERIC;
> > >
> > > case PG_TYPE_FLOAT4: return SQL_REAL;
> > > --- 217,223 ----
> > > case PG_TYPE_XID:
> > > case PG_TYPE_INT4: return SQL_INTEGER;
> > >
> > > ! case PG_TYPE_INT8: return SQL_CHAR;
> > > case PG_TYPE_NUMERIC: return SQL_NUMERIC;
> > >
> > > case PG_TYPE_FLOAT4: return SQL_REAL;
> > >
> >
> >
> > --
> > Bruce Momjian | http://candle.pha.pa.us
> > pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> > + If your life is a hard drive, | 830 Blythe Avenue
> > + Christ can be your backup. | Drexel Hill,
> > Pennsylvania 19026
> >
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

didn't Tom have an objection to this, or, at least, a concern about
forcing v2 specs?

On Tue, 23 Jan 2001, Bruce Momjian wrote:

>
> Patch applied. Thanks.
>
> [ Charset ISO-8859-1 unsupported, converting... ]
> > Hi Bruce,
> >
> > Did you accept this patch in the end or was it rejected?
> >
> > Regards, Dave.
> >
> > > -----Original Message-----
> > > From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> > > Sent: 16 January 2001 16:50
> > > To: Dave Page
> > > Cc: 'pgsql-hackers(at)postgresql(dot)org'
> > > Subject: Re: [HACKERS] ODBC Driver int8 Patch
> > >
> > >
> > > As I remember, the problem is that this makes us match the
> > > ODBC v2 spec,
> > > but then we would not match the v3 spec. Is that correct?
> > >
> > >
> > > [ Charset ISO-8859-1 unsupported, converting... ]
> > > > Hi,
> > > >
> > > > It was suggested that I post this patch here as no notice
> > > was taken of it
> > > > when posted to interfaces!
> > > >
> > > > This fixes problems with int8 columns which are reported by
> > > the driver as
> > > > SQL_BIGINT rather than SQL_CHAR as per the ODBC v2 spec.
> > > Specifically, I
> > > > have had problems with MS ADO - any queries that contain an
> > > int8 column in
> > > > the resultset will *always* return an empty recordset.
> > > >
> > > > Regards,
> > > >
> > > > Dave.
> > > >
> > > > *** pgtypes.c.orig Fri Dec 22 09:12:22 2000
> > > > --- pgtypes.c Fri Dec 22 09:12:22 2000
> > > > ***************
> > > > *** 217,223 ****
> > > > case PG_TYPE_XID:
> > > > case PG_TYPE_INT4: return SQL_INTEGER;
> > > >
> > > > ! case PG_TYPE_INT8: return SQL_BIGINT;
> > > > case PG_TYPE_NUMERIC: return SQL_NUMERIC;
> > > >
> > > > case PG_TYPE_FLOAT4: return SQL_REAL;
> > > > --- 217,223 ----
> > > > case PG_TYPE_XID:
> > > > case PG_TYPE_INT4: return SQL_INTEGER;
> > > >
> > > > ! case PG_TYPE_INT8: return SQL_CHAR;
> > > > case PG_TYPE_NUMERIC: return SQL_NUMERIC;
> > > >
> > > > case PG_TYPE_FLOAT4: return SQL_REAL;
> > > >
> > >
> > >
> > > --
> > > Bruce Momjian | http://candle.pha.pa.us
> > > pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> > > + If your life is a hard drive, | 830 Blythe Avenue
> > > + Christ can be your backup. | Drexel Hill,
> > > Pennsylvania 19026
> > >
> >
>
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> + If your life is a hard drive, | 830 Blythe Avenue
> + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
>

Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy(at)hub(dot)org secondary: scrappy(at){freebsd|postgresql}.org

>
> didn't Tom have an objection to this, or, at least, a concern about
> forcing v2 specs?

He said it looked good, I thought.

>
> On Tue, 23 Jan 2001, Bruce Momjian wrote:
>
> >
> > Patch applied. Thanks.
> >
> > [ Charset ISO-8859-1 unsupported, converting... ]
> > > Hi Bruce,
> > >
> > > Did you accept this patch in the end or was it rejected?
> > >
> > > Regards, Dave.
> > >
> > > > -----Original Message-----
> > > > From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> > > > Sent: 16 January 2001 16:50
> > > > To: Dave Page
> > > > Cc: 'pgsql-hackers(at)postgresql(dot)org'
> > > > Subject: Re: [HACKERS] ODBC Driver int8 Patch
> > > >
> > > >
> > > > As I remember, the problem is that this makes us match the
> > > > ODBC v2 spec,
> > > > but then we would not match the v3 spec. Is that correct?
> > > >
> > > >
> > > > [ Charset ISO-8859-1 unsupported, converting... ]
> > > > > Hi,
> > > > >
> > > > > It was suggested that I post this patch here as no notice
> > > > was taken of it
> > > > > when posted to interfaces!
> > > > >
> > > > > This fixes problems with int8 columns which are reported by
> > > > the driver as
> > > > > SQL_BIGINT rather than SQL_CHAR as per the ODBC v2 spec.
> > > > Specifically, I
> > > > > have had problems with MS ADO - any queries that contain an
> > > > int8 column in
> > > > > the resultset will *always* return an empty recordset.
> > > > >
> > > > > Regards,
> > > > >
> > > > > Dave.
> > > > >
> > > > > *** pgtypes.c.orig Fri Dec 22 09:12:22 2000
> > > > > --- pgtypes.c Fri Dec 22 09:12:22 2000
> > > > > ***************
> > > > > *** 217,223 ****
> > > > > case PG_TYPE_XID:
> > > > > case PG_TYPE_INT4: return SQL_INTEGER;
> > > > >
> > > > > ! case PG_TYPE_INT8: return SQL_BIGINT;
> > > > > case PG_TYPE_NUMERIC: return SQL_NUMERIC;
> > > > >
> > > > > case PG_TYPE_FLOAT4: return SQL_REAL;
> > > > > --- 217,223 ----
> > > > > case PG_TYPE_XID:
> > > > > case PG_TYPE_INT4: return SQL_INTEGER;
> > > > >
> > > > > ! case PG_TYPE_INT8: return SQL_CHAR;
> > > > > case PG_TYPE_NUMERIC: return SQL_NUMERIC;
> > > > >
> > > > > case PG_TYPE_FLOAT4: return SQL_REAL;
> > > > >
> > > >
> > > >
> > > > --
> > > > Bruce Momjian | http://candle.pha.pa.us
> > > > pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> > > > + If your life is a hard drive, | 830 Blythe Avenue
> > > > + Christ can be your backup. | Drexel Hill,
> > > > Pennsylvania 19026
> > > >
> > >
> >
> >
> > --
> > Bruce Momjian | http://candle.pha.pa.us
> > pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> > + If your life is a hard drive, | 830 Blythe Avenue
> > + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
> >
>
> Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
> Systems Administrator @ hub.org
> primary: scrappy(at)hub(dot)org secondary: scrappy(at){freebsd|postgresql}.org
>
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

>
> didn't Tom have an objection to this, or, at least, a concern about
> forcing v2 specs?

Oh, I remember now. Tom Lane was saying that we should vote if we want
v2 or v3 specs for ODBC. He said moving to v3 in beta may be a problem,
and you said this can be easily backed out, so I applied it. I think we
are stuck with v2 anyway.

>
> On Tue, 23 Jan 2001, Bruce Momjian wrote:
>
> >
> > Patch applied. Thanks.
> >
> > [ Charset ISO-8859-1 unsupported, converting... ]
> > > Hi Bruce,
> > >
> > > Did you accept this patch in the end or was it rejected?
> > >
> > > Regards, Dave.
> > >
> > > > -----Original Message-----
> > > > From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> > > > Sent: 16 January 2001 16:50
> > > > To: Dave Page
> > > > Cc: 'pgsql-hackers(at)postgresql(dot)org'
> > > > Subject: Re: [HACKERS] ODBC Driver int8 Patch
> > > >
> > > >
> > > > As I remember, the problem is that this makes us match the
> > > > ODBC v2 spec,
> > > > but then we would not match the v3 spec. Is that correct?
> > > >
> > > >
> > > > [ Charset ISO-8859-1 unsupported, converting... ]
> > > > > Hi,
> > > > >
> > > > > It was suggested that I post this patch here as no notice
> > > > was taken of it
> > > > > when posted to interfaces!
> > > > >
> > > > > This fixes problems with int8 columns which are reported by
> > > > the driver as
> > > > > SQL_BIGINT rather than SQL_CHAR as per the ODBC v2 spec.
> > > > Specifically, I
> > > > > have had problems with MS ADO - any queries that contain an
> > > > int8 column in
> > > > > the resultset will *always* return an empty recordset.
> > > > >
> > > > > Regards,
> > > > >
> > > > > Dave.
> > > > >
> > > > > *** pgtypes.c.orig Fri Dec 22 09:12:22 2000
> > > > > --- pgtypes.c Fri Dec 22 09:12:22 2000
> > > > > ***************
> > > > > *** 217,223 ****
> > > > > case PG_TYPE_XID:
> > > > > case PG_TYPE_INT4: return SQL_INTEGER;
> > > > >
> > > > > ! case PG_TYPE_INT8: return SQL_BIGINT;
> > > > > case PG_TYPE_NUMERIC: return SQL_NUMERIC;
> > > > >
> > > > > case PG_TYPE_FLOAT4: return SQL_REAL;
> > > > > --- 217,223 ----
> > > > > case PG_TYPE_XID:
> > > > > case PG_TYPE_INT4: return SQL_INTEGER;
> > > > >
> > > > > ! case PG_TYPE_INT8: return SQL_CHAR;
> > > > > case PG_TYPE_NUMERIC: return SQL_NUMERIC;
> > > > >
> > > > > case PG_TYPE_FLOAT4: return SQL_REAL;
> > > > >
> > > >
> > > >
> > > > --
> > > > Bruce Momjian | http://candle.pha.pa.us
> > > > pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> > > > + If your life is a hard drive, | 830 Blythe Avenue
> > > > + Christ can be your backup. | Drexel Hill,
> > > > Pennsylvania 19026
> > > >
> > >
> >
> >
> > --
> > Bruce Momjian | http://candle.pha.pa.us
> > pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> > + If your life is a hard drive, | 830 Blythe Avenue
> > + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
> >
>
> Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
> Systems Administrator @ hub.org
> primary: scrappy(at)hub(dot)org secondary: scrappy(at){freebsd|postgresql}.org
>
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

On Tue, 23 Jan 2001, Bruce Momjian wrote:

> >
> > didn't Tom have an objection to this, or, at least, a concern about
> > forcing v2 specs?
>
> Oh, I remember now. Tom Lane was saying that we should vote if we want
> v2 or v3 specs for ODBC. He said moving to v3 in beta may be a problem,
> and you said this can be easily backed out, so I applied it. I think we
> are stuck with v2 anyway.

ummm, I said it could be easily backed out *after* you applied it :) but,
as I also said, it looks insignificant enough that it can be changed
later, as required ...

>
>
> >
> > On Tue, 23 Jan 2001, Bruce Momjian wrote:
> >
> > >
> > > Patch applied. Thanks.
> > >
> > > [ Charset ISO-8859-1 unsupported, converting... ]
> > > > Hi Bruce,
> > > >
> > > > Did you accept this patch in the end or was it rejected?
> > > >
> > > > Regards, Dave.
> > > >
> > > > > -----Original Message-----
> > > > > From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> > > > > Sent: 16 January 2001 16:50
> > > > > To: Dave Page
> > > > > Cc: 'pgsql-hackers(at)postgresql(dot)org'
> > > > > Subject: Re: [HACKERS] ODBC Driver int8 Patch
> > > > >
> > > > >
> > > > > As I remember, the problem is that this makes us match the
> > > > > ODBC v2 spec,
> > > > > but then we would not match the v3 spec. Is that correct?
> > > > >
> > > > >
> > > > > [ Charset ISO-8859-1 unsupported, converting... ]
> > > > > > Hi,
> > > > > >
> > > > > > It was suggested that I post this patch here as no notice
> > > > > was taken of it
> > > > > > when posted to interfaces!
> > > > > >
> > > > > > This fixes problems with int8 columns which are reported by
> > > > > the driver as
> > > > > > SQL_BIGINT rather than SQL_CHAR as per the ODBC v2 spec.
> > > > > Specifically, I
> > > > > > have had problems with MS ADO - any queries that contain an
> > > > > int8 column in
> > > > > > the resultset will *always* return an empty recordset.
> > > > > >
> > > > > > Regards,
> > > > > >
> > > > > > Dave.
> > > > > >
> > > > > > *** pgtypes.c.orig Fri Dec 22 09:12:22 2000
> > > > > > --- pgtypes.c Fri Dec 22 09:12:22 2000
> > > > > > ***************
> > > > > > *** 217,223 ****
> > > > > > case PG_TYPE_XID:
> > > > > > case PG_TYPE_INT4: return SQL_INTEGER;
> > > > > >
> > > > > > ! case PG_TYPE_INT8: return SQL_BIGINT;
> > > > > > case PG_TYPE_NUMERIC: return SQL_NUMERIC;
> > > > > >
> > > > > > case PG_TYPE_FLOAT4: return SQL_REAL;
> > > > > > --- 217,223 ----
> > > > > > case PG_TYPE_XID:
> > > > > > case PG_TYPE_INT4: return SQL_INTEGER;
> > > > > >
> > > > > > ! case PG_TYPE_INT8: return SQL_CHAR;
> > > > > > case PG_TYPE_NUMERIC: return SQL_NUMERIC;
> > > > > >
> > > > > > case PG_TYPE_FLOAT4: return SQL_REAL;
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Bruce Momjian | http://candle.pha.pa.us
> > > > > pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> > > > > + If your life is a hard drive, | 830 Blythe Avenue
> > > > > + Christ can be your backup. | Drexel Hill,
> > > > > Pennsylvania 19026
> > > > >
> > > >
> > >
> > >
> > > --
> > > Bruce Momjian | http://candle.pha.pa.us
> > > pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> > > + If your life is a hard drive, | 830 Blythe Avenue
> > > + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
> > >
> >
> > Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
> > Systems Administrator @ hub.org
> > primary: scrappy(at)hub(dot)org secondary: scrappy(at){freebsd|postgresql}.org
> >
> >
>
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> + If your life is a hard drive, | 830 Blythe Avenue
> + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
>

Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy(at)hub(dot)org secondary: scrappy(at){freebsd|postgresql}.org

> didn't Tom have an objection to this, or, at least, a concern about
> forcing v2 specs?
>>
>> Oh, I remember now. Tom Lane was saying that we should vote if we want
>> v2 or v3 specs for ODBC. He said moving to v3 in beta may be a problem,
>> and you said this can be easily backed out, so I applied it. I think we
>> are stuck with v2 anyway.

I agree, we probably need to stick with the v2 spec for now. I just
wanted to see if anyone thought that changing the reported version
number would be a better patch ;-)

regards, tom lane