Unixware 713 probs

Lists: pgsql-generalpgsql-hackerspgsql-patches
From: ohp(at)pyrenet(dot)fr
To: pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Cc: Larry Rosenman <ler(at)lerctr(dot)org>
Subject: Unixware 713 probs
Date: 2003-09-07 18:22:30
Message-ID: Pine.UW2.4.53.0309072018290.28380@server.pyrenet.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general pgsql-hackers pgsql-patches

Hi,

I have those errors on Unixware 713 with yesterday and today's CVS
Script started on Sun Sep 7 20:19:16 2003
$ make
Using GNU make found at /usr/local/bin/gmake
/usr/local/bin/gmake -C doc all
gmake[1]: Entering directory `/home/postgres/pgsql/doc'
gmake[1]: Nothing to be done for `all'.
gmake[1]: Leaving directory `/home/postgres/pgsql/doc'
/usr/local/bin/gmake -C src all
gmake[1]: Entering directory `/home/postgres/pgsql/src'
/usr/local/bin/gmake -C port all
gmake[2]: Entering directory `/home/postgres/pgsql/src/port'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/home/postgres/pgsql/src/port'
/usr/local/bin/gmake -C backend all
gmake[2]: Entering directory `/home/postgres/pgsql/src/backend'
/usr/local/bin/gmake -C ../../src/port all
gmake[3]: Entering directory `/home/postgres/pgsql/src/port'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/home/postgres/pgsql/src/port'
/usr/local/bin/gmake -C access all
gmake[3]: Entering directory `/home/postgres/pgsql/src/backend/access'
/usr/local/bin/gmake -C common SUBSYS.o
gmake[4]: Entering directory `/home/postgres/pgsql/src/backend/access/common'
gmake[4]: `SUBSYS.o' is up to date.
gmake[4]: Leaving directory `/home/postgres/pgsql/src/backend/access/common'
/usr/local/bin/gmake -C gist SUBSYS.o
gmake[4]: Entering directory `/home/postgres/pgsql/src/backend/access/gist'
gmake[4]: `SUBSYS.o' is up to date.
gmake[4]: Leaving directory `/home/postgres/pgsql/src/backend/access/gist'
/usr/local/bin/gmake -C hash SUBSYS.o
gmake[4]: Entering directory `/home/postgres/pgsql/src/backend/access/hash'
gmake[4]: `SUBSYS.o' is up to date.
gmake[4]: Leaving directory `/home/postgres/pgsql/src/backend/access/hash'
/usr/local/bin/gmake -C heap SUBSYS.o
gmake[4]: Entering directory `/home/postgres/pgsql/src/backend/access/heap'
gmake[4]: `SUBSYS.o' is up to date.
gmake[4]: Leaving directory `/home/postgres/pgsql/src/backend/access/heap'
/usr/local/bin/gmake -C index SUBSYS.o
gmake[4]: Entering directory `/home/postgres/pgsql/src/backend/access/index'
gmake[4]: `SUBSYS.o' is up to date.
gmake[4]: Leaving directory `/home/postgres/pgsql/src/backend/access/index'
/usr/local/bin/gmake -C nbtree SUBSYS.o
gmake[4]: Entering directory `/home/postgres/pgsql/src/backend/access/nbtree'
gmake[4]: `SUBSYS.o' is up to date.
gmake[4]: Leaving directory `/home/postgres/pgsql/src/backend/access/nbtree'
/usr/local/bin/gmake -C rtree SUBSYS.o
gmake[4]: Entering directory `/home/postgres/pgsql/src/backend/access/rtree'
gmake[4]: `SUBSYS.o' is up to date.
gmake[4]: Leaving directory `/home/postgres/pgsql/src/backend/access/rtree'
/usr/local/bin/gmake -C transam SUBSYS.o
gmake[4]: Entering directory `/home/postgres/pgsql/src/backend/access/transam'
gmake[4]: `SUBSYS.o' is up to date.
gmake[4]: Leaving directory `/home/postgres/pgsql/src/backend/access/transam'
gmake[3]: Leaving directory `/home/postgres/pgsql/src/backend/access'
/usr/local/bin/gmake -C bootstrap all
gmake[3]: Entering directory `/home/postgres/pgsql/src/backend/bootstrap'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/home/postgres/pgsql/src/backend/bootstrap'
/usr/local/bin/gmake -C catalog all
gmake[3]: Entering directory `/home/postgres/pgsql/src/backend/catalog'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/home/postgres/pgsql/src/backend/catalog'
/usr/local/bin/gmake -C parser all
gmake[3]: Entering directory `/home/postgres/pgsql/src/backend/parser'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/home/postgres/pgsql/src/backend/parser'
/usr/local/bin/gmake -C commands all
gmake[3]: Entering directory `/home/postgres/pgsql/src/backend/commands'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/home/postgres/pgsql/src/backend/commands'
/usr/local/bin/gmake -C executor all
gmake[3]: Entering directory `/home/postgres/pgsql/src/backend/executor'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/home/postgres/pgsql/src/backend/executor'
/usr/local/bin/gmake -C lib all
gmake[3]: Entering directory `/home/postgres/pgsql/src/backend/lib'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/home/postgres/pgsql/src/backend/lib'
/usr/local/bin/gmake -C libpq all
gmake[3]: Entering directory `/home/postgres/pgsql/src/backend/libpq'
cc -O -Kinline,no_host -I../../../src/include -I/usr/local/include -c -o ip.o ip.c
UX:acomp: ERROR: "ip.c", line 416: Syntax error before or at: .
UX:acomp: WARNING: "ip.c", line 419: left operand of "." must be struct/union object
UX:acomp: WARNING: "ip.c", line 427: left operand of "." must be struct/union object
UX:acomp: WARNING: "ip.c", line 428: left operand of "." must be struct/union object
UX:acomp: WARNING: "ip.c", line 429: left operand of "." must be struct/union object
UX:acomp: WARNING: "ip.c", line 430: left operand of "." must be struct/union object
UX:acomp: ERROR: "ip.c", line 451: Syntax error before or at: .
UX:acomp: ERROR: "ip.c", line 452: invalid type combination
UX:acomp: WARNING: "ip.c", line 455: left operand of "." must be struct/union object
UX:acomp: WARNING: "ip.c", line 464: left operand of "." must be struct/union object
UX:acomp: WARNING: "ip.c", line 465: left operand of "." must be struct/union object
UX:acomp: WARNING: "ip.c", line 466: left operand of "." must be struct/union object
UX:acomp: WARNING: "ip.c", line 467: left operand of "." must be struct/union object
gmake[3]: *** [ip.o] Error 1
gmake[3]: Leaving directory `/home/postgres/pgsql/src/backend/libpq'
gmake[2]: *** [libpq-recursive] Error 2
gmake[2]: Leaving directory `/home/postgres/pgsql/src/backend'
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory `/home/postgres/pgsql/src'
gmake: *** [all] Error 2
*** Error code 2 (bu21)
UX:make: ERROR: fatal error.

Any clue?

Also, Has anyone tried DLZ (bind with postgresql) and can give me pointers
on it.

Many thanks in advance
--
Olivier PRENANT Tel: +33-5-61-50-97-00 (Work)
6, Chemin d'Harraud Turrou +33-5-61-50-97-01 (Fax)
31190 AUTERIVE +33-6-07-63-80-64 (GSM)
FRANCE Email: ohp(at)pyrenet(dot)fr
------------------------------------------------------------------------------
Make your life a dream, make your dream a reality. (St Exupery)


From: Larry Rosenman <ler(at)lerctr(dot)org>
To: ohp(at)pyrenet(dot)fr, pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unixware 713 probs
Date: 2003-09-07 19:18:59
Message-ID: 223640000.1062962339@lerlaptop.lerctr.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general pgsql-hackers pgsql-patches

--On Sunday, September 07, 2003 20:22:30 +0200 ohp(at)pyrenet(dot)fr wrote:

[snip]

> /usr/local/bin/gmake -C libpq all
> gmake[3]: Entering directory `/home/postgres/pgsql/src/backend/libpq'
> cc -O -Kinline,no_host -I../../../src/include -I/usr/local/include -c -o
> ip.o ip.c UX:acomp: ERROR: "ip.c", line 416: Syntax error before or at: .
> UX:acomp: WARNING: "ip.c", line 419: left operand of "." must be
> struct/union object UX:acomp: WARNING: "ip.c", line 427: left operand of
> "." must be struct/union object UX:acomp: WARNING: "ip.c", line 428: left
> operand of "." must be struct/union object UX:acomp: WARNING: "ip.c",
> line 429: left operand of "." must be struct/union object UX:acomp:
> WARNING: "ip.c", line 430: left operand of "." must be struct/union object
> UX:acomp: ERROR: "ip.c", line 451: Syntax error before or at: .
> UX:acomp: ERROR: "ip.c", line 452: invalid type combination
> UX:acomp: WARNING: "ip.c", line 455: left operand of "." must be
> struct/union object UX:acomp: WARNING: "ip.c", line 464: left operand of
> "." must be struct/union object UX:acomp: WARNING: "ip.c", line 465: left
> operand of "." must be struct/union object UX:acomp: WARNING: "ip.c",
> line 466: left operand of "." must be struct/union object UX:acomp:
line 416 is:

int32 s_addr;

s_addr is seen by the compiler as:

uint32 __S_un . __S_addr ;

We need to pick another name.

LER

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler(at)lerctr(dot)org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749


From: Larry Rosenman <ler(at)lerctr(dot)org>
To: ohp(at)pyrenet(dot)fr, pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Unixware 713 probs
Date: 2003-09-07 19:39:24
Message-ID: 245110000.1062963564@lerlaptop.lerctr.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general pgsql-hackers pgsql-patches

--On Sunday, September 07, 2003 14:19:00 -0500 Larry Rosenman
<ler(at)lerctr(dot)org> wrote:

>
>
> --On Sunday, September 07, 2003 20:22:30 +0200 ohp(at)pyrenet(dot)fr wrote:
>
> [snip]
>
>> /usr/local/bin/gmake -C libpq all
>> gmake[3]: Entering directory `/home/postgres/pgsql/src/backend/libpq'
>> cc -O -Kinline,no_host -I../../../src/include -I/usr/local/include -c -o
>> ip.o ip.c UX:acomp: ERROR: "ip.c", line 416: Syntax error before or at: .
>> UX:acomp: WARNING: "ip.c", line 419: left operand of "." must be
>> struct/union object UX:acomp: WARNING: "ip.c", line 427: left operand of
>> "." must be struct/union object UX:acomp: WARNING: "ip.c", line 428: left
>> operand of "." must be struct/union object UX:acomp: WARNING: "ip.c",
>> line 429: left operand of "." must be struct/union object UX:acomp:
>> WARNING: "ip.c", line 430: left operand of "." must be struct/union
>> object UX:acomp: ERROR: "ip.c", line 451: Syntax error before or at: .
>> UX:acomp: ERROR: "ip.c", line 452: invalid type combination
>> UX:acomp: WARNING: "ip.c", line 455: left operand of "." must be
>> struct/union object UX:acomp: WARNING: "ip.c", line 464: left operand of
>> "." must be struct/union object UX:acomp: WARNING: "ip.c", line 465: left
>> operand of "." must be struct/union object UX:acomp: WARNING: "ip.c",
>> line 466: left operand of "." must be struct/union object UX:acomp:
> line 416 is:
>
> int32 s_addr;
>
> s_addr is seen by the compiler as:
>
> uint32 __S_un . __S_addr ;
>
>
> We need to pick another name.
>
> LER
Here's a quickie patch I did to fix it.

Index: src/backend/libpq/ip.c
===================================================================
RCS file: /projects/cvsroot/pgsql-server/src/backend/libpq/ip.c,v
retrieving revision 1.21
diff -u -r1.21 ip.c
--- src/backend/libpq/ip.c 5 Sep 2003 23:07:21 -0000 1.21
+++ src/backend/libpq/ip.c 7 Sep 2003 19:36:06 -0000
@@ -413,10 +413,10 @@
{
struct sockaddr_in addr4;
struct sockaddr_in6 addr6;
- uint32 s_addr;
+ uint32 pg_s_addr;

memcpy(&addr4, addr, sizeof(addr4));
- s_addr = ntohl(addr4.sin_addr.s_addr);
+ pg_s_addr = ntohl(addr4.sin_addr.s_addr);

memset(&addr6, 0, sizeof(addr6));

@@ -424,10 +424,10 @@

addr6.sin6_addr.s6_addr[10] = 0xff;
addr6.sin6_addr.s6_addr[11] = 0xff;
- addr6.sin6_addr.s6_addr[12] = (s_addr >> 24) & 0xFF;
- addr6.sin6_addr.s6_addr[13] = (s_addr >> 16) & 0xFF;
- addr6.sin6_addr.s6_addr[14] = (s_addr >> 8) & 0xFF;
- addr6.sin6_addr.s6_addr[15] = (s_addr) & 0xFF;
+ addr6.sin6_addr.s6_addr[12] = (pg_s_addr >> 24) & 0xFF;
+ addr6.sin6_addr.s6_addr[13] = (pg_s_addr >> 16) & 0xFF;
+ addr6.sin6_addr.s6_addr[14] = (pg_s_addr >> 8) & 0xFF;
+ addr6.sin6_addr.s6_addr[15] = (pg_s_addr) & 0xFF;

memcpy(addr, &addr6, sizeof(addr6));
}
@@ -448,11 +448,11 @@
{
struct sockaddr_in addr4;
struct sockaddr_in6 addr6;
- uint32 s_addr;
+ uint32 pg_s_addr;
int i;

memcpy(&addr4, addr, sizeof(addr4));
- s_addr = ntohl(addr4.sin_addr.s_addr);
+ pg_s_addr = ntohl(addr4.sin_addr.s_addr);

memset(&addr6, 0, sizeof(addr6));

@@ -461,10 +461,10 @@
for (i = 0; i < 12; i++)
addr6.sin6_addr.s6_addr[i] = 0xff;

- addr6.sin6_addr.s6_addr[12] = (s_addr >> 24) & 0xFF;
- addr6.sin6_addr.s6_addr[13] = (s_addr >> 16) & 0xFF;
- addr6.sin6_addr.s6_addr[14] = (s_addr >> 8) & 0xFF;
- addr6.sin6_addr.s6_addr[15] = (s_addr) & 0xFF;
+ addr6.sin6_addr.s6_addr[12] = (pg_s_addr >> 24) & 0xFF;
+ addr6.sin6_addr.s6_addr[13] = (pg_s_addr >> 16) & 0xFF;
+ addr6.sin6_addr.s6_addr[14] = (pg_s_addr >> 8) & 0xFF;
+ addr6.sin6_addr.s6_addr[15] = (pg_s_addr) & 0xFF;

memcpy(addr, &addr6, sizeof(addr6));
}

also on my http://www.lerctr.org/~ler/postgresql page.

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler(at)lerctr(dot)org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

Attachment Content-Type Size
ip.patch application/octet-stream 2.0 KB

From: Stephan Szabo <sszabo(at)megazone(dot)bigpanda(dot)com>
To: Larry Rosenman <ler(at)lerctr(dot)org>
Cc: <ohp(at)pyrenet(dot)fr>, pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unixware 713 probs
Date: 2003-09-07 19:52:18
Message-ID: 20030907124932.V54554-100000@megazone.bigpanda.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general pgsql-hackers pgsql-patches


On Sun, 7 Sep 2003, Larry Rosenman wrote:

>
>
> --On Sunday, September 07, 2003 20:22:30 +0200 ohp(at)pyrenet(dot)fr wrote:
>
> [snip]
>
> > /usr/local/bin/gmake -C libpq all
> > gmake[3]: Entering directory `/home/postgres/pgsql/src/backend/libpq'
> > cc -O -Kinline,no_host -I../../../src/include -I/usr/local/include -c -o
> > ip.o ip.c UX:acomp: ERROR: "ip.c", line 416: Syntax error before or at: .
> > UX:acomp: WARNING: "ip.c", line 419: left operand of "." must be
> > struct/union object UX:acomp: WARNING: "ip.c", line 427: left operand of
> > "." must be struct/union object UX:acomp: WARNING: "ip.c", line 428: left
> > operand of "." must be struct/union object UX:acomp: WARNING: "ip.c",
> > line 429: left operand of "." must be struct/union object UX:acomp:
> > WARNING: "ip.c", line 430: left operand of "." must be struct/union object
> > UX:acomp: ERROR: "ip.c", line 451: Syntax error before or at: .
> > UX:acomp: ERROR: "ip.c", line 452: invalid type combination
> > UX:acomp: WARNING: "ip.c", line 455: left operand of "." must be
> > struct/union object UX:acomp: WARNING: "ip.c", line 464: left operand of
> > "." must be struct/union object UX:acomp: WARNING: "ip.c", line 465: left
> > operand of "." must be struct/union object UX:acomp: WARNING: "ip.c",
> > line 466: left operand of "." must be struct/union object UX:acomp:
> line 416 is:
>
> int32 s_addr;
>
> s_addr is seen by the compiler as:
>
> uint32 __S_un . __S_addr ;
>
>
> We need to pick another name.

As a side note, if s_addr is being defined by a common system header, you
should probably complain to your vendor as well, since that's amazingly
bad behavior on its part.


From: Larry Rosenman <ler(at)lerctr(dot)org>
To: Stephan Szabo <sszabo(at)megazone(dot)bigpanda(dot)com>
Cc: ohp(at)pyrenet(dot)fr, pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unixware 713 probs
Date: 2003-09-07 19:57:29
Message-ID: 265850000.1062964649@lerlaptop.lerctr.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general pgsql-hackers pgsql-patches

--On Sunday, September 07, 2003 12:52:18 -0700 Stephan Szabo
<sszabo(at)megazone(dot)bigpanda(dot)com> wrote:

>
> On Sun, 7 Sep 2003, Larry Rosenman wrote:
>
>>
>>
>> --On Sunday, September 07, 2003 20:22:30 +0200 ohp(at)pyrenet(dot)fr wrote:
>>
>> [snip]
>>
>> > /usr/local/bin/gmake -C libpq all
>> > gmake[3]: Entering directory `/home/postgres/pgsql/src/backend/libpq'
>> > cc -O -Kinline,no_host -I../../../src/include -I/usr/local/include -c
>> > -o ip.o ip.c UX:acomp: ERROR: "ip.c", line 416: Syntax error before or
>> > at: . UX:acomp: WARNING: "ip.c", line 419: left operand of "." must be
>> > struct/union object UX:acomp: WARNING: "ip.c", line 427: left operand
>> > of "." must be struct/union object UX:acomp: WARNING: "ip.c", line
>> > 428: left operand of "." must be struct/union object UX:acomp:
>> > WARNING: "ip.c", line 429: left operand of "." must be struct/union
>> > object UX:acomp: WARNING: "ip.c", line 430: left operand of "." must
>> > be struct/union object UX:acomp: ERROR: "ip.c", line 451: Syntax error
>> > before or at: . UX:acomp: ERROR: "ip.c", line 452: invalid type
>> > combination
>> > UX:acomp: WARNING: "ip.c", line 455: left operand of "." must be
>> > struct/union object UX:acomp: WARNING: "ip.c", line 464: left operand
>> > of "." must be struct/union object UX:acomp: WARNING: "ip.c", line
>> > 465: left operand of "." must be struct/union object UX:acomp:
>> > WARNING: "ip.c", line 466: left operand of "." must be struct/union
>> > object UX:acomp:
>> line 416 is:
>>
>> int32 s_addr;
>>
>> s_addr is seen by the compiler as:
>>
>> uint32 __S_un . __S_addr ;
>>
>>
>> We need to pick another name.
>
> As a side note, if s_addr is being defined by a common system header, you
> should probably complain to your vendor as well, since that's amazingly
> bad behavior on its part.

netinet/in_f.h:#define s_addr __S_un.__S_addr

Hrm. I'll ask, but this is SCO, so.........

Meanwhile, this header is in the field, so.........
I fired off a note to a contact at SCO.

LER

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler(at)lerctr(dot)org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749


From: Nailah Ogeer <ogeer(at)cs(dot)queensu(dot)ca>
To: <pgsql-general(at)postgresql(dot)org>
Cc: pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: Code insertion
Date: 2003-09-07 20:05:59
Message-ID: Pine.SOL.4.33.0309071559250.23551-100000@innovate
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general pgsql-hackers pgsql-patches

Hi all,
Just wondering if someone could help me with this rather specific problem.
I am trying to figure out where i should insert some code that basically
resets stats after a certain number of transactions(or sql statements)
have been executed. Collects Stats after some more statements have been
executed and continues to do this.
I need to access these stats so i store them in Shared memory.
The long term goal is to reset stats, collect stats, reset stats, collect
second set of stats, compare 1st and second stats. Therefore i can't have
the 1st or second stats rewritting itself.
I had this problem when i tried to insert the code in the Executor under
ExecutorRun().

Signed Very Desperate


From: Stephan Szabo <sszabo(at)megazone(dot)bigpanda(dot)com>
To: Larry Rosenman <ler(at)lerctr(dot)org>
Cc: <ohp(at)pyrenet(dot)fr>, pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unixware 713 probs
Date: 2003-09-07 21:03:41
Message-ID: 20030907140248.U56051-100000@megazone.bigpanda.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general pgsql-hackers pgsql-patches

On Sun, 7 Sep 2003, Larry Rosenman wrote:

>
>
> --On Sunday, September 07, 2003 12:52:18 -0700 Stephan Szabo
> <sszabo(at)megazone(dot)bigpanda(dot)com> wrote:
>
> >
> > On Sun, 7 Sep 2003, Larry Rosenman wrote:
> >
> >>
> >>
> >> --On Sunday, September 07, 2003 20:22:30 +0200 ohp(at)pyrenet(dot)fr wrote:
> >>
> >> [snip]
> >>
> >> > /usr/local/bin/gmake -C libpq all
> >> > gmake[3]: Entering directory `/home/postgres/pgsql/src/backend/libpq'
> >> > cc -O -Kinline,no_host -I../../../src/include -I/usr/local/include -c
> >> > -o ip.o ip.c UX:acomp: ERROR: "ip.c", line 416: Syntax error before or
> >> > at: . UX:acomp: WARNING: "ip.c", line 419: left operand of "." must be
> >> > struct/union object UX:acomp: WARNING: "ip.c", line 427: left operand
> >> > of "." must be struct/union object UX:acomp: WARNING: "ip.c", line
> >> > 428: left operand of "." must be struct/union object UX:acomp:
> >> > WARNING: "ip.c", line 429: left operand of "." must be struct/union
> >> > object UX:acomp: WARNING: "ip.c", line 430: left operand of "." must
> >> > be struct/union object UX:acomp: ERROR: "ip.c", line 451: Syntax error
> >> > before or at: . UX:acomp: ERROR: "ip.c", line 452: invalid type
> >> > combination
> >> > UX:acomp: WARNING: "ip.c", line 455: left operand of "." must be
> >> > struct/union object UX:acomp: WARNING: "ip.c", line 464: left operand
> >> > of "." must be struct/union object UX:acomp: WARNING: "ip.c", line
> >> > 465: left operand of "." must be struct/union object UX:acomp:
> >> > WARNING: "ip.c", line 466: left operand of "." must be struct/union
> >> > object UX:acomp:
> >> line 416 is:
> >>
> >> int32 s_addr;
> >>
> >> s_addr is seen by the compiler as:
> >>
> >> uint32 __S_un . __S_addr ;
> >>
> >>
> >> We need to pick another name.
> >
> > As a side note, if s_addr is being defined by a common system header, you
> > should probably complain to your vendor as well, since that's amazingly
> > bad behavior on its part.
>
> netinet/in_f.h:#define s_addr __S_un.__S_addr
>
> Hrm. I'll ask, but this is SCO, so.........
>
> Meanwhile, this header is in the field, so.........

Yeah, we obviously need to deal with it now, but hopefully at some
point in the future other people won't.


From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Larry Rosenman <ler(at)lerctr(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Unixware 713 probs
Date: 2003-09-07 21:34:45
Message-ID: 3F5BA475.5050805@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general pgsql-hackers pgsql-patches

Larry Rosenman wrote:

> Here's a quickie patch I did to fix it.

Patching this or not, if the function's called the backend will SEGV
either (at least on my 2.4.20 it does) because a IPV6 address is copied
in the memory space of a IPV4 address.

Regards,
Andreas


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
Cc: Larry Rosenman <ler(at)lerctr(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Unixware 713 probs
Date: 2003-09-08 00:57:04
Message-ID: 17147.1062982624@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general pgsql-hackers pgsql-patches

Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
> Larry Rosenman wrote:
>> Here's a quickie patch I did to fix it.

> Patching this or not, if the function's called the backend will SEGV
> either (at least on my 2.4.20 it does) because a IPV6 address is copied
> in the memory space of a IPV4 address.

I fixed that yesterday.

The s_addr name collision is unfortunate, but easily worked around;
fix committed as suggested by Larry.

regards, tom lane


From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Unixware 713 probs
Date: 2003-09-08 10:52:26
Message-ID: 3F5C5F6A.5090809@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general pgsql-hackers pgsql-patches

Tom Lane wrote:

>Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
>
>
>>Larry Rosenman wrote:
>>
>>
>>>Here's a quickie patch I did to fix it.
>>>
>>>
>
>
>
>>Patching this or not, if the function's called the backend will SEGV
>>either (at least on my 2.4.20 it does) because a IPV6 address is copied
>>in the memory space of a IPV4 address.
>>
>>
>
>I fixed that yesterday.
>
>
Ah, didn't notice, I thought you would announce this to have it tested.
I just did and it works as expected.

Regards,
Andreas


From: ohp(at)pyrenet(dot)fr
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>, Larry Rosenman <ler(at)lerctr(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Unixware 713 probs
Date: 2003-09-08 10:54:52
Message-ID: Pine.UW2.4.53.0309081253450.550@server.pyrenet.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general pgsql-hackers pgsql-patches

Thanks Tom,
I just cvs update'd and it ccompiles and regression tests pass.

I've have no time today to go further though
On Sun, 7 Sep 2003, Tom Lane wrote:

> Date: Sun, 07 Sep 2003 20:57:04 -0400
> From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> To: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
> Cc: Larry Rosenman <ler(at)lerctr(dot)org>, pgsql-patches(at)postgresql(dot)org
> Subject: Re: [PATCHES] Unixware 713 probs
>
> Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
> > Larry Rosenman wrote:
> >> Here's a quickie patch I did to fix it.
>
> > Patching this or not, if the function's called the backend will SEGV
> > either (at least on my 2.4.20 it does) because a IPV6 address is copied
> > in the memory space of a IPV4 address.
>
> I fixed that yesterday.
>
> The s_addr name collision is unfortunate, but easily worked around;
> fix committed as suggested by Larry.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org
>

--
Olivier PRENANT Tel: +33-5-61-50-97-00 (Work)
6, Chemin d'Harraud Turrou +33-5-61-50-97-01 (Fax)
31190 AUTERIVE +33-6-07-63-80-64 (GSM)
FRANCE Email: ohp(at)pyrenet(dot)fr
------------------------------------------------------------------------------
Make your life a dream, make your dream a reality. (St Exupery)