| Lists: | pgsql-hackers |
|---|
| From: | Tender Wang <tndrwang(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Tweak some codes format in gist.c |
| Date: | 2024-11-15 09:48:08 |
| Message-ID: | CAHewXNmD=K7XmsHq=L1SyyzZYvwU4oaMG9EKSSMe4OrXfykLzg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
I found some inconsistent code format in gist.c.
See the attached.
--
Thanks,
Tender Wang
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-some-codes-format-in-gist.c.patch | application/octet-stream | 863 bytes |
| From: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Tender Wang <tndrwang(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Tweak some codes format in gist.c |
| Date: | 2024-11-15 09:56:57 |
| Message-ID: | 93133064-0FE2-459C-9313-580B99B57F98@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
> On 15 Nov 2024, at 14:48, Tender Wang <tndrwang(at)gmail(dot)com> wrote:
>
> Hi,
>
> I found some inconsistent code format in gist.c.
> See the attached.
I’d suggest to combine such changes with some real code modification done nearby. There’s plenty of GiST patches on commitfest.
Thanks!
Best regards, Andrey Borodin.
| From: | Tender Wang <tndrwang(at)gmail(dot)com> |
|---|---|
| To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Tweak some codes format in gist.c |
| Date: | 2024-11-15 10:10:17 |
| Message-ID: | CAHewXNkW==eO=FPKFj8COR34iuaH2z2M_2bqw5oWs6qJ5eRWbA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> 于2024年11月15日周五 17:57写道：
>
>
> > On 15 Nov 2024, at 14:48, Tender Wang <tndrwang(at)gmail(dot)com> wrote:
> >
> > Hi,
> >
> > I found some inconsistent code format in gist.c.
> > See the attached.
>
> I’d suggest to combine such changes with some real code modification done
> nearby. There’s plenty of GiST patches on commitfest.
> Thanks!
>
> Yeah, agree. According to the nearby real code modification, I made the
change.
--
Thanks,
Tender Wang
| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Tender Wang <tndrwang(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Tweak some codes format in gist.c |
| Date: | 2024-11-18 04:50:25 |
| Message-ID: | ZzrHkYm0QGtNLsGV@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, Nov 15, 2024 at 02:56:57PM +0500, Andrey M. Borodin wrote:
> I’d suggest to combine such changes with some real code modification
> done nearby. There’s plenty of GiST patches on commitfest.
We do a lot of cosmetic fixes like this one, and sometimes we also
have the argument that these should not be blindly included in other
patches as that's just unrelated noise.
FWIW, I don't really mind in this case and this is consistent with the
surroundings, so applied on HEAD.
There is one more in trgm.h, though it's OK as-is, as well.
--
Michael
| From: | Tender Wang <tndrwang(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Tweak some codes format in gist.c |
| Date: | 2024-11-18 05:36:39 |
| Message-ID: | CAHewXNnJwZcVWP==h7ojCXsmsSWpO=sB=_LwX_AM5eDjW2O-mA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> 于2024年11月18日周一 12:50写道：
> On Fri, Nov 15, 2024 at 02:56:57PM +0500, Andrey M. Borodin wrote:
> > I’d suggest to combine such changes with some real code modification
> > done nearby. There’s plenty of GiST patches on commitfest.
>
> We do a lot of cosmetic fixes like this one, and sometimes we also
> have the argument that these should not be blindly included in other
> patches as that's just unrelated noise.
>
> FWIW, I don't really mind in this case and this is consistent with the
> surroundings, so applied on HEAD.
>
> There is one more in trgm.h, though it's OK as-is, as well.
> --
> Michael
>
Thanks for pushing.
--
Thanks,
Tender Wang