[PATCH] Comment typo in get_collation_name() comment

Lists: Postg메이저 토토 사이트SQL
From: ilmari(at)ilmari(dot)org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
To: pgsql-hackers(at)postgresql(dot)org
Subject: [PATCH] Comment typo in get_collation_name() comment
Date: 2017-10-30 17:38:54
Message-ID: d8jefpk4jtd.fsf@dalvik.ping.uio.no
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: Postg메이저 토토 사이트SQL

Hi Hackers,

The comment for get_collation_name() seems to have been copy-pasted from
get_constraint_name(), but missed one s/constraint/collation/.

Patch attached.

--
"I use RMS as a guide in the same way that a boat captain would use
a lighthouse. It's good to know where it is, but you generally
don't want to find yourself in the same spot." - Tollef Fog Heen

Attachment Content-Type Size
fix-get_collation_type-comment-typo.patch text/x-diff 637 bytes
From: ilmari(at)ilmari(dot)org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Comment typo in get_collation_name() comment
Date: 2018-01-03 21:58:27
Message-ID: d8jh8s2vc3g.fsf@dalvik.ping.uio.no
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker) writes:

> Hi Hackers,
>
> The comment for get_collation_name() seems to have been copy-pasted from
> get_constraint_name(), but missed one s/constraint/collation/.
>
> Patch attached.

Bump? Do I need to add this patch to the next commitfest? I thought
trivial comment typo patches like this generally got commited without
such bureaucracy?

- ilmari
--
"I use RMS as a guide in the same way that a boat captain would use
a lighthouse. It's good to know where it is, but you generally
don't want to find yourself in the same spot." - Tollef Fog Heen

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Comment typo in get_collation_name() comment
Date: 2018-01-03 22:14:08
Message-ID: 20180103221408.fpyga7at4kqfk577@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: Postg토토 핫SQL :

Dagfinn Ilmari Mannsåker wrote:
> ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker) writes:
>
> > Hi Hackers,
> >
> > The comment for get_collation_name() seems to have been copy-pasted from
> > get_constraint_name(), but missed one s/constraint/collation/.
> >
> > Patch attached.
>
> Bump? Do I need to add this patch to the next commitfest? I thought
> trivial comment typo patches like this generally got commited without
> such bureaucracy?

The problem is that pg-hackers is now too much traffic, so unregistered
patches customarily fall through cracks. Recommendation is to register
all patches to avoid that problem.

I have pushed it now.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

From: ilmari(at)ilmari(dot)org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Comment typo in get_collation_name() comment
Date: 2018-01-03 22:28:28
Message-ID: d8j4lo2vapf.fsf@dalvik.ping.uio.no
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:

> The problem is that pg-hackers is now too much traffic, so unregistered
> patches customarily fall through cracks. Recommendation is to register
> all patches to avoid that problem.

I shall keep that in mind and register even trivial patches in future if
they don't get picked up straight away.

> I have pushed it now.

Thanks!

- ilmari
--
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
the consequences of." -- Skud's Meta-Law