| Lists: | Postg젠 토토SQL : Postg젠 토토SQL 메일 링리스트 : 2019-03-27 이후 PGSQL WWW 15:50 |
|---|
| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org> |
| Subject: | Incorrect email address in the auth.py module |
| Date: | 2019-03-27 13:12:26 |
| Message-ID: | Bk2m7cUcBzU8MndxidLFDkPok8uyf5xHx5-xcegc4VLQqONaNUPL2snvnYO8xz1Ly-bF97zgnOzTx7TPeiDxN69rDGacJCy0mhc4xTLIbhc=@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-www |
Poking around in the CF app I noticed that the auth.py module for integrating with
the community authentication was out of sync with the copy in the main pgweb repo.
Turns out the copy in the CF app is the most up to date as it has fixed the email
address in the account merging support email template. The attached patch merges
the changes from the CF app copy into the one in the pgweb repo. Unless there are
objections I plan to apply this soon.
This also fixes an adjacent typo spotted in the process.
cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| auth_py_sync.patch | application/octet-stream | 2.0 KB |
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Incorrect email address in the auth.py module |
| Date: | 2019-03-27 14:51:59 |
| Message-ID: | CABUevEx9Fa_faOkNzsqwoGePWHBkkKg0tWWqLX-JPaK9obrakA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-www |
On Wed, Mar 27, 2019 at 2:12 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> Poking around in the CF app I noticed that the auth.py module for
> integrating with
> the community authentication was out of sync with the copy in the main
> pgweb repo.
> Turns out the copy in the CF app is the most up to date as it has fixed
> the email
> address in the account merging support email template. The attached patch
> merges
> the changes from the CF app copy into the one in the pgweb repo. Unless
> there are
> objections I plan to apply this soon.
>
> This also fixes an adjacent typo spotted in the process.
>
That update breaks the commit hook. Have you perhaps forgotten to instlall
it? :)
Please make sure that a "pep8" run (with version 2.2.0 or compatible, as
that's what's used on the prod servers) passes on the code before pushing!
Easiest way is to make sure that the tools/githook/pre-commit is linked
into your git hooks directory.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Incorrect email address in the auth.py module |
| Date: | 2019-03-27 15:50:05 |
| Message-ID: | zZs-Ir-mezjBf_tvR4hOaHXDvpOlWa652ocaIKmY9E2E5t06xAZ0_iNgW_qFQe-XHHnY4bF2X4T3deFJmZCm1QJ7_VXA3gAhsfgQEsH0-zI=@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | Postg젠 토토SQL : Postg젠 토토SQL 메일 링리스트 : 2019-03-27 이후 PGSQL WWW 15:50 |
On Wednesday, March 27, 2019 3:51 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Wed, Mar 27, 2019 at 2:12 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> Poking around in the CF app I noticed that the auth.py module for integrating with
>> the community authentication was out of sync with the copy in the main pgweb repo.
>> Turns out the copy in the CF app is the most up to date as it has fixed the email
>> address in the account merging support email template. The attached patch merges
>> the changes from the CF app copy into the one in the pgweb repo. Unless there are
>> objections I plan to apply this soon.
>>
>> This also fixes an adjacent typo spotted in the process.
>
> That update breaks the commit hook. Have you perhaps forgotten to instlall it? :)
Aha, nice catch. This repo does indeed not run any commit hooks, will fix.
> Please make sure that a "pep8" run (with version 2.2.0 or compatible, as that's what's used on the prod servers) passes on the code before pushing! Easiest way is to make sure that the tools/githook/pre-commit is linked into your git hooks directory.
Gotcha, thanks. Any objections to the patch when the above mentioned breakage is resolved?
cheers ./daniel
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Incorrect email address in the auth.py module |
| Date: | 2019-03-28 10:27:06 |
| Message-ID: | CABUevEwFvzuPm=SuQKQiF8Hqv58QU2T4w=+smqTP68iYKA0EVw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | Postg배트맨 토토SQL : Postg배트맨 토토SQL 메일 링리스트 : 2019-03-28 이후 PGSQL WWW 10:27 |
On Wed, Mar 27, 2019 at 4:50 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> On Wednesday, March 27, 2019 3:51 PM, Magnus Hagander <magnus(at)hagander(dot)net>
> wrote:
>
> On Wed, Mar 27, 2019 at 2:12 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> Poking around in the CF app I noticed that the auth.py module for
>> integrating with
>> the community authentication was out of sync with the copy in the main
>> pgweb repo.
>> Turns out the copy in the CF app is the most up to date as it has fixed
>> the email
>> address in the account merging support email template. The attached patch
>> merges
>> the changes from the CF app copy into the one in the pgweb repo. Unless
>> there are
>> objections I plan to apply this soon.
>>
>> This also fixes an adjacent typo spotted in the process.
>>
>
> That update breaks the commit hook. Have you perhaps forgotten to instlall
> it? :)
>
>
> Aha, nice catch. This repo does indeed not run any commit hooks, will fix.
>
> Please make sure that a "pep8" run (with version 2.2.0 or compatible, as
> that's what's used on the prod servers) passes on the code before pushing!
> Easiest way is to make sure that the tools/githook/pre-commit is linked
> into your git hooks directory.
>
>
> Gotcha, thanks. Any objections to the patch when the above mentioned
> breakage is resolved?
>
>
No, looks good.
Of course, then we have to sync it out to all the other repos. But for just
typos, that can wait :)
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>