| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
| Cc: | Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>, Mark Kirkwood <markir(at)coretech(dot)co(dot)nz>, pgsql-hackers-win32(at)postgresql(dot)org |
| Subject: | Re: Win32 testing needed |
| Date: | 2004-08-06 14:37:59 |
| Message-ID: | 11680.1091803079@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers-win32 |
Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
> Claudio Natoli wrote:
>> Agree. Or rather, better if src/port doesn't use backend DATA.
> Not easy to avoid, many functions are really macros using backend data.
Perhaps we should insist that nothing in src/port can include postgres.h.
If it needs something that's not in c.h, it doesn't belong in src/port.
These are the affected files:
$ grep postgres.h *.c
copydir.c:#include "postgres.h"
dirmod.c:#include "postgres.h"
exec.c:#include "postgres.h"
pipe.c:#include "postgres.h"
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-08-06 15:44:23 | Re: Point in Time recovery on Win32 |
| Previous Message | Tom Lane | 2004-08-06 14:17:07 | Re: Win32 testing needed |