| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Joel Jacobson <joel(at)trustly(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] pg_dump: Sort overloaded functions in deterministic order |
| Date: | 2012-07-05 18:29:54 |
| Message-ID: | 18078.1341512994@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Joel Jacobson <joel(at)trustly(dot)com> writes:
> New version, made a typo in last one.
I'm not particularly happy with the idea of adding a sortkey field to
DumpableObject as such, when most object types don't need it. That just
bloats the code and pg_dump's memory consumption. It would be better to
modify the already-existing object-type-specific special cases in
DOTypeNameCompare to take additional information into account as needed.
BTW, I see no reason to be adding extra calls of
pg_get_function_identity_arguments. What is wrong with the funcsig or
aggsig strings that the code already computes?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Lumby | 2012-07-05 18:31:32 | Re: proposal and patch : support INSERT INTO...RETURNING with partitioned table using rule |
| Previous Message | Josh Berkus | 2012-07-05 18:21:44 | Re: Schema version management |