Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Richard Guo <guofenglinux(at)gmail(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Subject: Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
Date: 2024-04-19 09:47:43
Message-ID: CAJ7c6TMCoum0nBoBCLJnVGNf2mcaDQ91S0Q32Ek_2codk7w9ew@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> > Fair point. PFA the alternative version of the patch.
> >
>
> Thanks. Committed.

Thanks. I see a few pieces of code that use special FOO_NUMBER enum
values instead of a macro. Should we refactor these pieces
accordingly? PFA another patch.

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
v1-0001-Use-macro-to-define-the-number-of-enum-values.patch application/octet-stream 4.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2024-04-19 10:08:50 Re: Okay to remove mention of mystery @ and ~ operators?
Previous Message Aleksander Alekseev 2024-04-19 09:16:50 Re: Trigger violates foreign key constraint