| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS |
| Date: | 2024-05-12 11:57:43 |
| Message-ID: | e9f02a1d-a1e0-45d2-9572-4a16b4d658d4@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19.04.24 11:47, Aleksander Alekseev wrote:
> Thanks. I see a few pieces of code that use special FOO_NUMBER enum
> values instead of a macro. Should we refactor these pieces
> accordingly? PFA another patch.
I think this is a sensible improvement.
But please keep the trailing commas on the last enum items.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-05-12 12:21:15 | Re: Logging which interface was connected to in log_line_prefix |
| Previous Message | Peter Eisentraut | 2024-05-12 11:53:17 | Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs |